[fix] Daggy and DaggyCore always require Qt6 Network#103
Merged
synacker merged 5 commits intosynacker:masterfrom Oct 16, 2025
Merged
[fix] Daggy and DaggyCore always require Qt6 Network#103synacker merged 5 commits intosynacker:masterfrom
synacker merged 5 commits intosynacker:masterfrom
Conversation
Signed-off-by: Uilian Ries <uilianries@gmail.com>
Signed-off-by: Uilian Ries <uilianries@gmail.com>
3 tasks
Contributor
Author
|
The CI failed due to a configuration error, nothing related to this PR changes. |
uilianries
commented
Oct 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
When building the project with the CMake option
CONSOLE=ON, it fails to build due the following error:You can see the full build log: daggy-2.2.3-linux-gcc11-shared.log
It occurs because both DaggyCore and Daggy (console app) include the header file
Precompiled.hpp, which needsQHostAddress. As theQHostAddressis part of the Qt Network module and both Daggy projects always usePrecompiled.hpp, theQt6::NetworkCMake target should always be listed as required.This PR adds Qt6 Network as a required module, and lists its CMake target to be used by both Daggy (console app) and DaggyCode (library).
Regards.