[LiveComponent] Fix NoModificationAllowedError when closing the error modal twice#3501
Open
Amoifr wants to merge 1 commit intosymfony:2.xfrom
Open
[LiveComponent] Fix NoModificationAllowedError when closing the error modal twice#3501Amoifr wants to merge 1 commit intosymfony:2.xfrom
Amoifr wants to merge 1 commit intosymfony:2.xfrom
Conversation
… modal twice Assigning to `outerHTML` throws `NoModificationAllowedError` when the element has no parent, which happens when the server-error overlay is closed twice in quick succession (e.g. a double click, or a click + Escape within the same tick). Switch to `Element.remove()`, which is idempotent and safe to call on a detached element. Adds a regression test that documents the close-twice invariant. Fixes symfony#3496
carsonbot
added
Bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the server-error overlay is closed twice in quick succession (double-click, or a click + Escape within the same tick), the second close throws:
The root cause (nicely identified by @maarten-mymmo in #3496) is that both close listeners call
closeModal(modal)with the same captured reference: the first call detaches the element viamodal.outerHTML = '', and the second call then hits the DOM spec rule thatouterHTMLcan't be set on a parent-less element.Fix
Swap
modal.outerHTML = ''forElement.remove(), which is idempotent and safe on detached elements. Same observable effect (element gone), one less footgun.Test plan
src/LiveComponent/assets/test/unit/controller/error.test.tspass (3 existing + 1 new).closing the error modal twice does not throwdocuments the invariant.NoModificationAllowedErroronouterHTMLfor detached elements, so the test can't actively catch a regression toouterHTML. It still guards the "close-twice → clean state, no throw" contract and serves as living documentation.