[build-script] Remove redundant LLDB DWARFImporter test run#87583
Open
medismailben wants to merge 1 commit intoswiftlang:mainfrom
Open
[build-script] Remove redundant LLDB DWARFImporter test run#87583medismailben wants to merge 1 commit intoswiftlang:mainfrom
medismailben wants to merge 1 commit intoswiftlang:mainfrom
Conversation
Now that the LLDB test infrastructure generates clangimporter and dwarfimporter variants automatically for @swiftTest-decorated tests, there is no need to run lit a second time with --setting symbols.use-swift-clangimporter=false. Remove the second invocation and the now-unused FILTER_SWIFT_API_OPTION variable. Signed-off-by: Med Ismail Bennani <[email protected]>
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci please smoke test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the LLDB test infrastructure generates clangimporter and dwarfimporter variants automatically for @swiftTest-decorated tests, there is no need to run lit a second time with
--setting symbols.use-swift-clangimporter=false.
Remove the second invocation and the now-unused FILTER_SWIFT_API_OPTION variable.