[Sema] Allow Sendable conformance for structs with global-actor-isolated stored properties#87580
Open
aydinomer00 wants to merge 1 commit intoswiftlang:mainfrom
Conversation
…d properties Actor-isolated properties in classes already skip the Sendable member type check, but structs did not have the same exemption. This caused an inconsistency where a final class with a @mainactor let of non-Sendable type was accepted as Sendable, but a struct with the same property was rejected. Move the actor-isolation skip check outside the isa<ClassDecl> guard so it applies uniformly to all nominal types (classes, structs, enums). Resolves swiftlang#87543
aydinomer00
requested review from
hborla,
ktoso,
slavapestov and
xedin
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actor-isolated stored properties can only be accessed from within their isolation domain, so they are already safe regardless of whether the enclosing type is a class or a struct. However, checkSendableInstanceStorage() only skipped the Sendable member check for actor-isolated properties when the enclosing type was a class. This meant a
final classwith@MainActor letof non-Sendable type was accepted as Sendable, but an identical struct was rejected.This change lifts the actor-isolation guard out of the
isa<ClassDecl>block so it applies uniformly to all nominal types.Changes:
S13,S14)Resolves #87543