Open
Conversation
ghost
commented
Jul 20, 2023
Author
ghost
left a comment
There was a problem hiding this comment.
Hi there! Good job on the refactoring work. However, there are a couple of changes needed:
In packages/react-error-overlay/src/containers/StackTrace.js:
- The
useEffecthook on lines 36-39 has a reference error.isInternalUrlis not defined in the scope of the hook. Please check this.
In packages/react-scripts/fixtures/kitchensink/template/src/App.js:
- The
setFeaturemethod has been removed from theAppclass component but it might be used elsewhere in the code. Please ensure that this change does not break any other parts of the code.
Keep up the good work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR converts the class components in the codebase to functional components. This improves the codebase by using the latest React features and simplifying the component structure.
Changes Made
AppandBuiltEmittercomponents inpackages/react-scripts/fixtures/kitchensink/template/src/App.jsinto functional components.StackTracecomponent inpackages/react-error-overlay/src/containers/StackTrace.jsinto a functional component.Checklist
Screenshots (if applicable)
N/A
Related Issues
Closes #6
Fixes #6.
To checkout this PR branch, run the following command in your terminal: