Skip to content

Set initial capacity for metaElems in read.go #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
google-labs-jules wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Set initial capacity for metaElems in read.go #363

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion read.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,11 @@ func (r *reader) readHeader() ([]*Element, error) {
return nil, fmt.Errorf("error reading DICOM header element: %w", err)
}

metaElems := []*Element{maybeMetaLen} // TODO: maybe set capacity to a reasonable initial size
// Initialize with a capacity of 20 to avoid reallocations for standard DICOM headers.
// 20 is chosen as a reasonable upper bound for the number of File Meta Information elements
// typically found (Group 0002).
metaElems := make([]*Element, 0, 20)
metaElems = append(metaElems, maybeMetaLen)
metaElementGroupLengthDefined := true
if maybeMetaLen.Tag != tag.FileMetaInformationGroupLength || maybeMetaLen.Value.ValueType() != Ints {
// MetaInformationGroupLength is not present or of the wrong value type.
Expand Down