Update channel limits and VBAP 1.0.3.2 by muellmusik · Pull Request #376 · supercollider/sc3-plugins

muellmusik · 2024-06-10T13:08:36Z

Adjustments ported from new PD code for VBAP 1.0.3.2. LS amounts allocated dynamically.

dyfer · 2024-07-02T22:11:52Z

Thanks @muellmusik
Could you kindly fix formatting to match the rest of the code? And get rid of the whitespace changes? (These can be viewed in the "Files Changed" tab above)

dyfer · 2025-03-24T12:14:29Z

@muellmusik are you planning to make the requested changes or do you suggest pulling this in as is?

muellmusik · 2025-09-12T09:02:12Z

Sorry @dyfer, I somehow didn't see these.

Could you kindly fix formatting to match the rest of the code? And get rid of the whitespace changes? (These can be viewed in the "Files Changed" tab above)

Could you be more specific as to what you want me to do? The code is mostly from old PD code and is a big mix of tabs and spaces. I can change line 288 and 290 to be one or the other if that's what you mean, but it won't make things consistent so I'm not sure what's best. Also which formatting would you like changed?

@muellmusik are you planning to make the requested changes or do you suggest pulling this in as is?

I'm okay with that personally. It's a little awkward at the moment as I changed machines and haven't managed to set up a build chain yet (Apple dev license woes...) but I can make changes if need. My personal view is that strict standards for formatting have been dispiriting for some new contributors, and thus aren't really worth it, though I know others have differing views.

dyfer · 2025-09-19T21:38:27Z

Could you be more specific as to what you want me to do? The code is mostly from old PD code and is a big mix of tabs and spaces. I can change line 288 and 290 to be one or the other if that's what you mean, but it won't make things consistent so I'm not sure what's best. Also which formatting would you like changed?

I only would like to avoid changes to lines where the only change is whitespace change (spaces<->tabs typically). You can see them in the "File changed" tab of the GH web UI. Example:

By formatting changes I meant changing indentation, but I only really meant that for the lines where this was the only change in the given line, e.g. line 170/174. Sorry I wasn't clear.

I went through the changes and marked where I can see the whitespace change, if you can't see them for some reason. As I wrote elsewhere, I don't want to block this PR based on the whitespace changes, but I would personally prefer not to have them.

My personal view is that strict standards for formatting have been dispiriting for some new contributors, and thus aren't really worth it, though I know others have differing views.

I don't think this request is about any strict standards. I just didn't think that whitespace-only changes are desired. We don't have automatic formatting set up for sc3-plugins so if you're just pushing back on my request to remove whitespace changes, then that's fine, we can merge with the (unnecessary) whitespace changes. This is an unofficial / semi-official repo anyway.

There have been heated discussions in the past on formatting, but I thought that we are past that... If there is an ongoing discussion about formatting as a substantial issue for new contributors, I'm not aware of it.

dyfer · 2025-09-19T21:10:04Z

source/VBAPUGens/sc/vbap.sc

+      			}, {table_size = table_size - 1;});
+  			});


dyfer · 2025-09-19T21:10:13Z

source/VBAPUGens/sc/vbap.sc

 		//"triplet_amount before stripping: %\n".postf(sets.size);
 		sets = sets.reject({|set|
-			i1 = set.chanOffsets[0];
+    			i1 = set.chanOffsets[0];


dyfer · 2025-09-19T21:10:25Z

source/VBAPUGens/sc/vbap.sc

-		+ abs(this.vec_angle(speakers[i], speakers[k]))
-		+ abs(this.vec_angle(speakers[j], speakers[k])));
+          	+ abs(this.vec_angle(speakers[i], speakers[k]))
+          	+ abs(this.vec_angle(speakers[j], speakers[k])));


dyfer · 2025-09-19T21:10:41Z

source/VBAPUGens/sc/vbap.sc

-		var length, result;
-		result = VBAPSpeaker.new;
-		result.x = (v1.y * v2.z ) - (v1.z * v2.y);
-		result.y = (v1.z * v2.x ) - (v1.x * v2.z);
+  		var length, result;
+  		result = VBAPSpeaker.new;
+  		result.x = (v1.y * v2.z ) - (v1.z * v2.y);
+  		result.y = (v1.z * v2.x ) - (v1.x * v2.z);


dyfer · 2025-09-19T21:10:56Z

source/VBAPUGens/sc/vbap.sc

-			(this.vec_length(v1) * this.vec_length(v2));
+  		var inner;
+  		inner = ((v1.x*v2.x) + (v1.y*v2.y) + (v1.z*v2.z)) /
+  			(this.vec_length(v1) * this.vec_length(v2));


dyfer · 2025-09-19T21:11:26Z

source/VBAPUGens/sc/vbap.sc

-		triplet_amount = sets.size;
-		//"triplet_amount: %\n".postf(triplet_amount);
+ 		triplet_amount = sets.size;
+ 		//"triplet_amount: %\n".postf(triplet_amount);


dyfer · 2025-09-19T21:11:39Z

source/VBAPUGens/sc/vbap.sc

-			lp1 = speakers[set.chanOffsets[0]];
+    		lp1 = speakers[set.chanOffsets[0]];


dyfer · 2025-09-19T21:12:00Z

source/VBAPUGens/sc/vbap.sc

-		^super.newCopyArgs(chanOffsets);
-	}
+  		^super.newCopyArgs(chanOffsets);
+  	}


dyfer · 2025-09-19T21:12:15Z

source/VBAPUGens/VBAP.cpp

-		}
+ 	  	}
 	}
-
+	


dyfer · 2025-09-19T21:13:06Z

source/VBAPUGens/VBAP.cpp

+			final_gs[i]=0.f; 
+	}


whitespace (end of the first line and and beginning of the second line)

mtmccrea

If going back to fix white space, I might also recommend clearing out unused variables, which in a few places look to have simply been commented out.

muellmusik · 2025-09-29T14:59:28Z

@dyfer No worries, I'll fix it thanks for marking. I hope this didn't come off as 'heated' in any way. :-)

muellmusik · 2025-10-09T11:00:25Z

Okay @dyfer. I think that's all fixed now. Let me know if there's something more needed. Sorry it took so long.

muellmusik · 2025-10-09T11:15:45Z

Oh and removed commented out vars, @mtmccrea

as per supercollider/sc3-plugins#376

dyfer · 2025-10-10T01:35:12Z

Thanks @muellmusik
I've run this locally and it seems to work (though I'm not sure if the examples from the help file work as they should... in any case, there doesn't seem to be a change from the previous version).
Speaking of helpfiles, I noticed that the helpfile also mentions the version of the PD code (in multiple places). Could you update that? Or remove the version number from the help altogether?

muellmusik · 2025-10-15T13:59:49Z

Speaking of helpfiles, I noticed that the helpfile also mentions the version of the PD code (in multiple places). Could you update that? Or remove the version number from the help altogether?

Done

dyfer · 2025-10-15T18:34:31Z

(in multiple places).

https://github.com/supercollider/sc3-plugins/blob/topic/vbap-improvements/source/VBAPUGens/sc/HelpSource/Classes/VBAPSpeaker.schelp#L11
https://github.com/supercollider/sc3-plugins/blob/topic/vbap-improvements/source/VBAPUGens/sc/HelpSource/Classes/VBAPSpeakerArray.schelp#L11

EDIT: I guess I should've been specific and write "in multiple files".

If you don't think it's worth changing these, please let me know.

Adjustments ported from new PD code. LS amounts allocated dynamically. VBAP 1.0.3.2 Remove ls hardcoded limit Signed-off-by: Scott Wilson <i@scottwilson.ca>

muellmusik · 2025-10-20T08:19:28Z

EDIT: I guess I should've been specific and write "in multiple files".

If you don't think it's worth changing these, please let me know.

LOL. I never use this stuff anymore tbh, so my memory of where I wrote such things 15 years ago is a bit fuzzy!

Anyway. Done now. Can we please merge though? haha

dyfer · 2025-10-21T09:05:13Z

Thanks!

muellmusik mentioned this pull request Jun 10, 2024

VBAP with more than 55 channels #374

Closed

capital-G added the comp: plugins label Aug 30, 2024

dyfer reviewed Sep 19, 2025

View reviewed changes

mtmccrea reviewed Sep 25, 2025

View reviewed changes

muellmusik force-pushed the topic/vbap-improvements branch 2 times, most recently from 0503638 to 256b6b9 Compare October 9, 2025 10:58

muellmusik force-pushed the topic/vbap-improvements branch from 256b6b9 to 63fd757 Compare October 9, 2025 11:15

mtmccrea added a commit to ambisonictoolkit/SphericalDesign that referenced this pull request Oct 9, 2025

make tolerance a variable

7a0a74c

as per supercollider/sc3-plugins#376

muellmusik force-pushed the topic/vbap-improvements branch from 63fd757 to 157f2d8 Compare October 15, 2025 13:59

Update channel limits and VBAP 1.032

777ad66

Adjustments ported from new PD code. LS amounts allocated dynamically. VBAP 1.0.3.2 Remove ls hardcoded limit Signed-off-by: Scott Wilson <i@scottwilson.ca>

muellmusik force-pushed the topic/vbap-improvements branch from 157f2d8 to 777ad66 Compare October 20, 2025 08:17

dyfer approved these changes Oct 21, 2025

View reviewed changes

dyfer merged commit e5551af into main Oct 21, 2025
5 of 9 checks passed

github-project-automation bot moved this from Waiting for review response to Done in SuperCollider development Oct 21, 2025

		lp1 = speakers[set.chanOffsets[0]];
		lp1 = speakers[set.chanOffsets[0]];

Conversation

muellmusik commented Jun 10, 2024

Uh oh!

dyfer commented Jul 2, 2024

Uh oh!

dyfer commented Mar 24, 2025

Uh oh!

muellmusik commented Sep 12, 2025

Uh oh!

dyfer commented Sep 19, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mtmccrea left a comment

Choose a reason for hiding this comment

Uh oh!

muellmusik commented Sep 29, 2025

Uh oh!

muellmusik commented Oct 9, 2025

Uh oh!

muellmusik commented Oct 9, 2025

Uh oh!

dyfer commented Oct 10, 2025

Uh oh!

muellmusik commented Oct 15, 2025

Uh oh!

dyfer commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

muellmusik commented Oct 20, 2025

Uh oh!

dyfer commented Oct 21, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dyfer commented Oct 15, 2025 •

edited

Loading