legacy bug fix for the trainer assuming there exists a model.mode att…#545
Merged
legacy bug fix for the trainer assuming there exists a model.mode att…#545
Conversation
…ribute when its not really required
dalloliogm
pushed a commit
to dalloliogm/PyHealth
that referenced
this pull request
Nov 26, 2025
…ribute when its not really required (sunlabuiuc#545) Co-authored-by: John Wu <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes minor improvements to the
BaseModelclass inpyhealth/models/base_model.pyto enhance backward compatibility and code readability. The main changes include adding a legacy API attribute and refactoring assertion statements for clarity.Backward compatibility:
modeattribute to theBaseModelclass to maintain compatibility with legacy trainer code.Code readability:
get_output_size,get_loss_function, andprepare_y_probmethods to use a more readable multi-line format. [1] [2] [3]…ribute when its not really required