Conversation
mamazu
force-pushed
the
documenting-frankenphp
branch
from
dbe4f83 to
2074385
Compare
| @@ -0,0 +1,63 @@ | |||
| Running Franken PHP | |||
There was a problem hiding this comment.
would call this FrankenPHP via Docker
as you can use also frankenphp standalone binary which is different to use. Same for the file name.
There was a problem hiding this comment.
Yes, that's a good idea. Did that.
| After setting up the container you might also want to update the `DATABASE_URL` variable in the php service (by default it assumes postgres). At least note that FrankenPHP and the default Sulu mysql container have different default credentials. | ||
|
|
||
| If you have some other modifications in your set up be sure to copy all changes of the `docker-compose*` files to the `compose.yaml` and `compose.override.yaml`. | ||
|
|
||
| After all this, the Sulu default configuration is not used anymore and can be removed: | ||
| .. code-block:: bash | ||
| rm docker-compose.yaml | ||
| rm docker-compose.override.yaml |
There was a problem hiding this comment.
Not understanding this parts sulu use compose.yaml files like Symfony and Dunglas Symfony Docker. The docker-compose.yaml are not in use by any of them.
There was a problem hiding this comment.
Yes, that's why I would recommend to delete them. That way we don't confuse the user of which of the compose file is now being used.
There was a problem hiding this comment.
I would remove that sentence about docker+compose, we should not consider here that somebody uses may older version of something. This docs is more used for new setup projects which are uptodate. Think else this confuses more.
There was a problem hiding this comment.
The point should be that whatever you had in your old Sulu docker-compose.yaml had will no longer be used when running the compose.yaml. That's why you need to merge any changes from the Sulu config into the FrankenPHP config. And if you remove the old file you get conflicts when Sulu changes something in the default config.
Co-authored-by: Alexander Schranz <alexander@sulu.io>
2 participants
What's in this PR?
Explaining how adding frankenphp works.
Why?
This is also officially supported by Sulu so we might as well document it.