update: upgrading node version for admin build#802
Open
lubomirfiala wants to merge 2 commits intosulu:2.xfrom
Open
update: upgrading node version for admin build#802lubomirfiala wants to merge 2 commits intosulu:2.xfrom
lubomirfiala wants to merge 2 commits intosulu:2.xfrom
Conversation
| docker run --rm --interactive --tty --volume ${PWD}:/var/project node:20-alpine3.18 /bin/sh | ||
|
|
||
| # for completion: using another node version is possible by adjusting the tag of the node image | ||
| # docker run --rm --interactive --tty --volume ${PWD}:/var/project node:12.21.0 /bin/bash |
Member
There was a problem hiding this comment.
we should also change this line e.g. using 18.19.0
alexander-schranz
requested changes
May 22, 2024
Member
alexander-schranz
left a comment
alexander-schranz
left a comment
There was a problem hiding this comment.
Thx for the merge request, some small change requests.
| .. code-block:: bash | ||
|
|
||
| docker run --rm --interactive --tty --volume ${PWD}:/var/project node:14.16.0 /bin/bash | ||
| docker run --rm --interactive --tty --volume ${PWD}:/var/project node:20-alpine3.18 /bin/sh |
Member
There was a problem hiding this comment.
I would not add -alpine as they might sometimes make problems so I would keep with the default image and the /bin/bash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version of node container recommended by documentation can no longer be used with sulu 2.6..