Conversation
Collaborator
|
Yay! Love it, though we could setup a gh-pages that is deployed each time we update Look on Cunningham ? https://github.com/suitenumerique/cunningham/blob/main/.circleci/config.yml#L123C3-L123C20 Anyway the two approaches can live together, thoughts @jbpenrath @PanchoutNathan ? |
Member
Author
|
I already created an app on scalingo, just like the integrations repo. not a fan of pointing a *.gouv.fr to github |
Collaborator
|
I agree with NV, both approaches are possible, so what do we do? This PR is starting to look dated. @NathanVss @sylvinus @jbpenrath |
This allows do deploy on Scalingo with the LaSuite buildpack
Add padding and fullscreen layout to the icon gallery story for a better visual presentation.
Document how to deploy the storybook to Scalingo production.
Vite bundles CSS into assets/preview-*.css with relative font URLs resolving to /assets/, but staticDirs served fonts at /. Adding a second mapping to /assets ensures fonts are found in production while keeping the root mapping for dev mode.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.