Skip to content

Conversation

@AntoLC
Copy link
Collaborator

@AntoLC AntoLC commented Jan 9, 2026

Purpose

It exists a dedicated endpoint to list favorite documents.
Better use it to avoid relying on the general documents listing endpoint.

The favorite_list route was returning all the favorite with depth=0. We
also want to see favorited document with a depth > 0

@AntoLC AntoLC self-assigned this Jan 9, 2026
@AntoLC AntoLC linked an issue Jan 9, 2026 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Jan 9, 2026

Size Change: +210 B (+0.01%)

Total Size: 4.17 MB

Filename Size Change
apps/impress/out/_next/static/64261ab0/_buildManifest.js 0 B -848 B (removed) 🏆
apps/impress/out/_next/static/cd01d84f/_buildManifest.js 848 B +848 B (new file) 🆕

compressed-size-action

@lunika lunika force-pushed the fix/correct-favorite-endpoint branch from 8895d69 to 3ef978e Compare January 20, 2026 13:39
It exists a dedicated endpoint to list favorite
documents. Better use it to avoid relying on the
general documents listing endpoint.
@lunika lunika added the preview label Jan 20, 2026
@lunika lunika force-pushed the fix/correct-favorite-endpoint branch from 3ef978e to 6a72256 Compare January 20, 2026 13:55
@github-actions
Copy link

🚀 Preview will be available at https://1782-docs.ppr-docs.beta.numerique.gouv.fr/

You can use the existing account with these credentials:

  • username: docs
  • password: docs

You can also create a new account if you want to.

Once this Pull Request is merged, the preview will be destroyed.

@AntoLC AntoLC changed the title ♻️(frontend) use dedicated favorite_list route 🐛(frontend) display children in favorite Jan 20, 2026
The favorite_list route was returning all the favorite with depth=0. We
also want to see favorited document with a depth > 0
@AntoLC AntoLC force-pushed the fix/correct-favorite-endpoint branch from 6a72256 to dd02b9d Compare January 20, 2026 15:26
@AntoLC AntoLC requested a review from lunika January 20, 2026 15:29
@AntoLC AntoLC merged commit dd02b9d into main Jan 20, 2026
39 of 42 checks passed
@AntoLC AntoLC deleted the fix/correct-favorite-endpoint branch January 20, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Display pin sub-documents in the left panel

3 participants