Skip to content

Conversation

@StephanMeijer
Copy link
Collaborator

@StephanMeijer StephanMeijer commented Nov 15, 2025

Purpose

We can now import docx and and md files just by dropping them into the docs grid area.
To do so we added a new container "docspec", which uses the docspec service to convert these formats to Blocknote format.

Import of (markdown) documents. See #1567 #1569.

Demo

Docs.1.online-video-cutter.com.mp4

@github-actions
Copy link

github-actions bot commented Nov 15, 2025

Size Change: +19.2 kB (+0.46%)

Total Size: 4.19 MB

Filename Size Change
apps/impress/out/_next/static/530f952d/_buildManifest.js 0 B -849 B (removed) 🏆
apps/impress/out/_next/static/a4056189/_buildManifest.js 850 B +850 B (new file) 🆕
apps/impress/out/_next/static/chunks/1217.js 784 kB +784 kB (new file) 🆕
apps/impress/out/_next/static/chunks/5893.js 0 B -767 kB (removed) 🏆
apps/impress/out/_next/static/chunks/8495.js 65.1 kB +2.51 kB (+4.01%)

compressed-size-action

@github-actions
Copy link

🚀 Preview will be available at https://1609-docs.ppr-docs.beta.numerique.gouv.fr/

You can use the existing account with these credentials:

  • username: docs
  • password: docs

You can also create a new account if you want to.

Once this Pull Request is merged, the preview will be destroyed.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@StephanMeijer StephanMeijer force-pushed the feature/doc-import branch 2 times, most recently from a9c28e9 to 9cef0a0 Compare January 8, 2026 11:01
@virgile-dev
Copy link
Collaborator

Holy molly ! Let me try it.

Copy link
Member

@lunika lunika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job !

lunika pushed a commit that referenced this pull request Jan 20, 2026
Refactored converter services based on PR #1609 review comments:
- Renamed parameter to `data` across all convert methods for consistency
- Replaced recursive call with explicit sequential calls for readability
- Hardcoded CONVERSION_API_SECURE=True in Production class for security
- Removed unused YdocConverter import from viewsets.py
- Updated tests to match new error message wording

Signed-off-by: Stephan Meijer <me@stephanmeijer.com>
@lunika lunika force-pushed the feature/doc-import branch from 6fe1053 to b3e5e8c Compare January 20, 2026 10:06
lunika pushed a commit that referenced this pull request Jan 20, 2026
Refactored converter services based on PR #1609 review comments:
- Renamed parameter to `data` across all convert methods for consistency
- Replaced recursive call with explicit sequential calls for readability
- Hardcoded CONVERSION_API_SECURE=True in Production class for security
- Removed unused YdocConverter import from viewsets.py
- Updated tests to match new error message wording

Signed-off-by: Stephan Meijer <me@stephanmeijer.com>
@lunika lunika force-pushed the feature/doc-import branch from b3e5e8c to 74066a6 Compare January 20, 2026 10:27
@AntoLC AntoLC force-pushed the feature/doc-import branch from c355dd4 to 24e2809 Compare January 20, 2026 12:01
AntoLC pushed a commit that referenced this pull request Jan 20, 2026
Refactored converter services based on PR #1609 review comments:
- Renamed parameter to `data` across all convert methods for consistency
- Replaced recursive call with explicit sequential calls for readability
- Hardcoded CONVERSION_API_SECURE=True in Production class for security
- Removed unused YdocConverter import from viewsets.py
- Updated tests to match new error message wording

Signed-off-by: Stephan Meijer <me@stephanmeijer.com>
@AntoLC AntoLC force-pushed the feature/doc-import branch from 24e2809 to 8d92f7c Compare January 20, 2026 12:02
AntoLC pushed a commit that referenced this pull request Jan 20, 2026
Refactored converter services based on PR #1609 review comments:
- Renamed parameter to `data` across all convert methods for consistency
- Replaced recursive call with explicit sequential calls for readability
- Hardcoded CONVERSION_API_SECURE=True in Production class for security
- Removed unused YdocConverter import from viewsets.py
- Updated tests to match new error message wording

Signed-off-by: Stephan Meijer <me@stephanmeijer.com>
@AntoLC AntoLC force-pushed the feature/doc-import branch from 8d92f7c to 6107fc8 Compare January 20, 2026 12:04
AntoLC pushed a commit that referenced this pull request Jan 20, 2026
Refactored converter services based on PR #1609 review comments:
- Renamed parameter to `data` across all convert methods for consistency
- Replaced recursive call with explicit sequential calls for readability
- Hardcoded CONVERSION_API_SECURE=True in Production class for security
- Removed unused YdocConverter import from viewsets.py
- Updated tests to match new error message wording

Signed-off-by: Stephan Meijer <me@stephanmeijer.com>
@AntoLC AntoLC force-pushed the feature/doc-import branch from 6107fc8 to b16c641 Compare January 20, 2026 12:20
AntoLC pushed a commit that referenced this pull request Jan 20, 2026
Refactored converter services based on PR #1609 review comments:
- Renamed parameter to `data` across all convert methods for consistency
- Replaced recursive call with explicit sequential calls for readability
- Hardcoded CONVERSION_API_SECURE=True in Production class for security
- Removed unused YdocConverter import from viewsets.py
- Updated tests to match new error message wording

Signed-off-by: Stephan Meijer <me@stephanmeijer.com>
@AntoLC AntoLC force-pushed the feature/doc-import branch from b16c641 to 45fc608 Compare January 20, 2026 13:30
StephanMeijer and others added 9 commits January 21, 2026 10:27
We can now import documents in formats .docx and .md.
To do so we added a new container "docspec", which
uses the docspec service to convert
these formats to Blocknote format.

More here: #1567 #1569.
Adapt the docs grid title bar to align with the
new design. We will add a upload button in a
future iteration.
Add import document area with drag and drop
support in the docs grid component.
We can now import docx and and md files just
by dropping them into the designated area.

We are using the `react-dropzone` library to
handle the drag and drop functionality.
Updated docspec service image from 2.0.0 to 2.4.4 to
include latest features and bug fixes.

Signed-off-by: Stephan Meijer <me@stephanmeijer.com>
Added comprehensive tests covering DocSpec converter service,
converter orchestration, and document creation with file uploads.

Tests validate DOCX and Markdown conversion workflows, error
handling, service availability, and edge cases including empty
files and Unicode filenames.

Signed-off-by: Stephan Meijer <me@stephanmeijer.com>
Refactored converter services based on PR #1609 review comments:
- Renamed parameter to `data` across all convert methods for consistency
- Replaced recursive call with explicit sequential calls for readability
- Hardcoded CONVERSION_API_SECURE=True in Production class for security
- Removed unused YdocConverter import from viewsets.py
- Updated tests to match new error message wording

Signed-off-by: Stephan Meijer <me@stephanmeijer.com>
Added Helm templates for docspec deployment and service to enable
document specification conversion in the Kubernetes environment.
Updated Tiltfile, compose.yml, and Helm values to
configure docspec integration alongside the
backend converter service for document import functionality.
We now check the size and the extension of the uploaded file for
conversion.
Image and document uploaded were limited to 10MB.
For the conversion service, we allow up to 20MB.
For the dev and feature environment, we have to increase this value
accordingly.
@AntoLC AntoLC force-pushed the feature/doc-import branch from 45fc608 to 1b2840b Compare January 21, 2026 09:28
The max size and allowed extensions for document
import are now fetched from the application
configuration.
This ensures consistency across the app and
allows for easier updates to these
settings in the future.
@AntoLC AntoLC force-pushed the feature/doc-import branch from 1b2840b to b8bdcbf Compare January 21, 2026 09:31
@AntoLC AntoLC merged commit b8bdcbf into main Jan 21, 2026
27 of 28 checks passed
@AntoLC AntoLC deleted the feature/doc-import branch January 21, 2026 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(DocSpec) Infrastuctural integration with La Suite (Docker Compose, Helm) (DocSpec) Integration between DocSpec and La Suite Docs

5 participants