feat(parse): add proto::extensions::SimpleExtensionDeclaration parser#170
Open
ilikepi63 wants to merge 18 commits intosubstrait-io:mainfrom
Open
feat(parse): add proto::extensions::SimpleExtensionDeclaration parser#170ilikepi63 wants to merge 18 commits intosubstrait-io:mainfrom
proto::extensions::SimpleExtensionDeclaration parser#170ilikepi63 wants to merge 18 commits intosubstrait-io:mainfrom
Conversation
|
Cameron Harris seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
mbrobbel
reviewed
Apr 4, 2024
src/parse/proto/extensions/simple_extension_declaration/extension_function.rs
Outdated
Show resolved
Hide resolved
src/parse/proto/extensions/simple_extension_declaration/extension_function.rs
Outdated
Show resolved
Hide resolved
| type Parsed = ExtensionFunction; | ||
| type Error = SimpleExtensionDeclarationError; | ||
|
|
||
| fn parse(self, _ctx: &mut C) -> Result<Self::Parsed, Self::Error> { |
Member
There was a problem hiding this comment.
This parser should add the function to the context, checking that the referenced extension uri is valid, the used anchor is unique, and that the definition contains a matching function with the given name in the referenced extension.
src/parse/proto/extensions/simple_extension_declaration/extension_function.rs
Outdated
Show resolved
Hide resolved
Comment on lines
+1
to
+2
| use crate::parse::{Anchor, Context, Parse}; | ||
| use crate::proto; |
| type Parsed = ExtensionTypeVariation; | ||
| type Error = SimpleExtensionDeclarationError; | ||
|
|
||
| fn parse(self, _ctx: &mut C) -> Result<Self::Parsed, Self::Error> { |
src/parse/proto/extensions/simple_extension_declaration/mapping_type.rs
Outdated
Show resolved
Hide resolved
src/parse/proto/extensions/simple_extension_declaration/simple_extension_declaration.rs
Outdated
Show resolved
Hide resolved
|
|
||
| Ok(SimpleExtensionDeclaration { | ||
| mapping_type: mapping_type | ||
| .map(|mapping_type| mapping_type.parse(ctx).ok()) |
Member
There was a problem hiding this comment.
We don't want this to silently error on parser errors.
mbrobbel
changed the title
proto::extensions::SimpleExtensionDeclaration parser
…ion_function.rs Co-authored-by: Matthijs Brobbel <[email protected]>
…ion_function.rs Co-authored-by: Matthijs Brobbel <[email protected]>
…ion_function.rs Co-authored-by: Matthijs Brobbel <[email protected]>
…ion_type.rs Co-authored-by: Matthijs Brobbel <[email protected]>
…ion_type.rs Co-authored-by: Matthijs Brobbel <[email protected]>
…ion_type_variation.rs Co-authored-by: Matthijs Brobbel <[email protected]>
…ion_type_variation.rs Co-authored-by: Matthijs Brobbel <[email protected]>
…g_type.rs Co-authored-by: Matthijs Brobbel <[email protected]>
…_extension_declaration.rs Co-authored-by: Matthijs Brobbel <[email protected]>
Co-authored-by: Matthijs Brobbel <[email protected]>
mbrobbel
reviewed
Apr 10, 2024
src/parse/context.rs
Outdated
Comment on lines
+42
to
+50
| /// Add a [ExtensionFunction] to this context. Must return an error for duplicate | ||
| /// anchors, when the URI is not supported or if the definition does not contain a matching function with the given name. | ||
| /// | ||
| /// This function must eagerly resolve and parse the simple extension, returning an | ||
| /// error if either fails. | ||
| fn add_extension_function( | ||
| &mut self, | ||
| extension_function: &ExtensionFunction, | ||
| ) -> Result<&SimpleExtensions, ContextError>; |
Member
There was a problem hiding this comment.
The return types and comments of these functions should be updated.
src/parse/proto/extensions/simple_extension_declaration/simple_extension_declaration.rs
Outdated
Show resolved
Hide resolved
src/parse/proto/extensions/simple_extension_declaration/simple_extension_declaration.rs
Outdated
Show resolved
Hide resolved
…_extension_declaration.rs Co-authored-by: Matthijs Brobbel <[email protected]>
…_extension_declaration.rs Co-authored-by: Matthijs Brobbel <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a parser for proto::extensions::SimpleExtensionDeclaration that parses the declaration.