Conversation
|
new release will break metals The Optional type was removed from LSP. I will try to create a PR, as soon as I get to my laptop. I will also try to see if other repos are affected. |
✅ Deploy Preview for sublime-lsp ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
I still see it at Line 20 in e298124 |
|
I didn't notice when it be was added back. Thanks Janos. |
Co-authored-by: Предраг Николић <idmpepe@gmail.com>
Co-authored-by: Предраг Николић <idmpepe@gmail.com>
|
I've type-checked all LSP packages and didn't find any to be broken by this next release. https://github.com/sublimelsp/LSP-serenata is still not updated to run in python 3.8 so it was broken already. |
Based on the history of that file it was never removed :) |
|
Ok, so we did remove LSP-metals still imports |
|
Created a PR at metals-sublime -> |
|
I think it would be also ok to bring back Optional in LSP types.py file, to not block the release and not break LSP-metals. Once LSP-metals merges the above PR, we can remove Optional again |
Actually I had |
I think it's time to release new version.
Prepared curated list to exclude non-essential changes or changes/fixes to stuff that was introduced within this cycle.
Will not merge this given how release process works but will use for release.