Skip to content

prepare release notes#2837

Closed
rchl wants to merge 8 commits intomainfrom
feat/release
Closed

prepare release notes#2837
rchl wants to merge 8 commits intomainfrom
feat/release

Conversation

@rchl
Copy link
Copy Markdown
Member

@rchl rchl commented Mar 28, 2026

I think it's time to release new version.

Prepared curated list to exclude non-essential changes or changes/fixes to stuff that was introduced within this cycle.

Will not merge this given how release process works but will use for release.

@predragnikolic
Copy link
Copy Markdown
Member

predragnikolic commented Mar 28, 2026

new release will break metals
https://github.com/scalameta/metals-sublime/blob/da60d359c5de2cb2e40f3d81017472721f249a46/core/metals.py#L13

The Optional type was removed from LSP.

I will try to create a PR, as soon as I get to my laptop.

I will also try to see if other repos are affected.

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 28, 2026

Deploy Preview for sublime-lsp ready!

Name Link
🔨 Latest commit 8bccada
🔍 Latest deploy log https://app.netlify.com/projects/sublime-lsp/deploys/69c7e880559d56000858977f
😎 Deploy Preview https://deploy-preview-2837--sublime-lsp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@jwortmann
Copy link
Copy Markdown
Member

The Optional type was removed from LSP.

I still see it at

from typing import Optional

@predragnikolic
Copy link
Copy Markdown
Member

I didn't notice when it be was added back. Thanks Janos.

rchl and others added 5 commits March 28, 2026 16:38
Co-authored-by: Предраг Николић <idmpepe@gmail.com>
Co-authored-by: Предраг Николић <idmpepe@gmail.com>
@rchl
Copy link
Copy Markdown
Member Author

rchl commented Mar 28, 2026

I've type-checked all LSP packages and didn't find any to be broken by this next release.

https://github.com/sublimelsp/LSP-serenata is still not updated to run in python 3.8 so it was broken already.

predragnikolic
predragnikolic previously approved these changes Mar 28, 2026
@rchl
Copy link
Copy Markdown
Member Author

rchl commented Mar 28, 2026

new release will break metals https://github.com/scalameta/metals-sublime/blob/da60d359c5de2cb2e40f3d81017472721f249a46/core/metals.py#L13

The Optional type was removed from LSP.

I will try to create a PR, as soon as I get to my laptop.

I will also try to see if other repos are affected.

Based on the history of that file it was never removed :)

@predragnikolic predragnikolic dismissed their stale review March 28, 2026 16:02

let me verify something

@predragnikolic
Copy link
Copy Markdown
Member

predragnikolic commented Mar 28, 2026

Ok, so we did remove Optional in this commit
ead1085#diff-476d0275847cfb60ebc00c73c76d5c5e6595f5b70dd8c659d4f0fd1a854f49eeL27
but not from LSP/plugin/core/typing.py,
but rather we removed it from LSP/plugin/core/types.py

LSP-metals still imports Optional from LSP/plugin/core/types.py
https://github.com/scalameta/metals-sublime/blob/master/core/metals.py#L13

@predragnikolic
Copy link
Copy Markdown
Member

Created a PR at metals-sublime ->
scalameta/metals-sublime#124

@predragnikolic
Copy link
Copy Markdown
Member

I think it would be also ok to bring back Optional in LSP types.py file, to not block the release and not break LSP-metals.

Once LSP-metals merges the above PR, we can remove Optional again

@rchl
Copy link
Copy Markdown
Member Author

rchl commented Mar 28, 2026

I've type-checked all LSP packages and didn't find any to be broken by this next release.

https://github.com/sublimelsp/LSP-serenata is still not updated to run in python 3.8 so it was broken already.

Actually I had reportAttributeAccessIssue rule disabled which is the one reporting import issues. Re-checked all now.

@rchl
Copy link
Copy Markdown
Member Author

rchl commented Mar 28, 2026

@rchl rchl closed this Mar 28, 2026
@rchl rchl deleted the feat/release branch March 28, 2026 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants