Update Strimzi Metrics Reporter to version 0.3.0 by OwenCorrigan76 · Pull Request #12392 · strimzi/strimzi-kafka-operator

OwenCorrigan76 · 2026-02-05T15:23:37Z

Type of change

Enhancement / new feature

Description

Current Strimzi is using Srimzi Metrics Reporter 0.2.0. This PR updates the version to 0.3.0-rc1 in the kafka-thirdparty-libs directories and updates the code base to use Strimzi Metrtics Reporter 0.3.0-rc1.

Checklist

Write tests
Make sure all tests pass
Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally
Update CHANGELOG.md

mimaison · 2026-02-05T16:20:56Z

...or/src/test/java/io/strimzi/operator/cluster/model/KafkaConnectConfigurationBuilderTest.java

-        configMap.put("metric.reporters", StrimziMetricsReporterConfig.KAFKA_CLASS);
-        configMap.put("kafka.metrics.reporters", StrimziMetricsReporterConfig.YAMMER_CLASS);
+        configMap.put("metric.reporters", StrimziMetricsReporterConfig.CLIENT_CLASS);
+        configMap.put("kafka.metrics.reporters", StrimziMetricsReporterConfig.SERVER_YAMMER_CLASS);


kafka.metrics.reporters is not a Connect configuration. I'm not sure what this test is doing but this should not need to be set.

Thanks for spotting. Removed.

codecov · 2026-02-05T16:48:34Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.01%. Comparing base (568706e) to head (aa5a887).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #12392      +/-   ##
============================================
+ Coverage     74.99%   75.01%   +0.01%     
+ Complexity     6651     6650       -1     
============================================
  Files           373      373              
  Lines         25367    25367              
  Branches       3376     3376              
============================================
+ Hits          19025    19029       +4     
+ Misses         4956     4948       -8     
- Partials       1386     1390       +4

Files with missing lines	Coverage Δ
...cluster/model/KafkaBrokerConfigurationBuilder.java	`92.97% <100.00%> (ø)`
...luster/model/KafkaConnectConfigurationBuilder.java	`94.29% <100.00%> (ø)`
...tor/cluster/model/KafkaMirrorMaker2Connectors.java	`90.71% <100.00%> (ø)`

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

scholzj · 2026-02-05T16:49:05Z

CHANGELOG.md

+* Update Strimzi Metrics Reporter to version 0.3.0.
+  This version splits the metrics reporter into separate client and server artifacts with updated class names:
+  * `io.strimzi.kafka.metrics.prometheus.ClientMetricsReporter` for Kafka clients (Bridge, Connect, MirrorMaker 2)
+  * `io.strimzi.kafka.metrics.prometheus.ServerKafkaMetricsReporter` for Kafka brokers (Kafka metrics)
+  * `io.strimzi.kafka.metrics.prometheus.ServerYammerMetricsReporter` for Kafka brokers (Yammer metrics)


Is this really relevant? The user does not configure any of this, or?

I guess not, as the user does not configure this. Removed

scholzj · 2026-02-05T16:50:47Z

docker-images/artifacts/kafka-thirdparty-libs/4.0.x/pom.xml

        <dependency>
            <groupId>io.strimzi</groupId>
-            <artifactId>metrics-reporter</artifactId>
+            <artifactId>client-metrics-reporter</artifactId>


Isn't the client part a dependency of the server part? So should we really have both?

No, you are correct. Refactored

im-konge · 2026-02-06T15:18:09Z

/gha run pipeline=regression

github-actions · 2026-02-06T15:18:43Z

⏳ System test verification started: link

The following 6 job(s) will be executed:

regression-brokers-and-security-amd64 (oracle-vm-8cpu-32gb-x86-64)
regression-operators-amd64 (oracle-vm-8cpu-32gb-x86-64)
regression-operands-amd64 (oracle-vm-8cpu-32gb-x86-64)
regression-brokers-and-security-arm64 (oracle-vm-8cpu-32gb-arm64)
regression-operators-arm64 (oracle-vm-8cpu-32gb-arm64)
regression-operands-arm64 (oracle-vm-8cpu-32gb-arm64)

Tests will start after successful build completion.

im-konge · 2026-02-06T15:19:00Z

@OwenCorrigan76 as the 0.3.0 is still not released and this PR is testing the RC1, I would move it to draft for now. Once the metrics-reporter is released, it should be opened for review.

github-actions · 2026-02-06T15:32:02Z

❌ System test verification failed: link

im-konge · 2026-02-06T20:08:19Z

There is one failing test for the metrics-reporter - for the Bridge.

Error:  Errors: 
Error:  io.strimzi.systemtest.metrics.StrimziMetricsReporterST.testKafkaBridgeMetrics
Error:    Run 1: StrimziMetricsReporterST.testKafkaBridgeMetrics:230 » Runtime
Error:    Run 2: StrimziMetricsReporterST.testKafkaBridgeMetrics:230 » Runtime

but we cannot do anything about it, until new Bridge version is released.
I think that we even cannot merge this PR once metrics-reporter 0.3.0 is officially released -> at least until we have new version of Bridge.

github-actions · 2026-02-06T21:07:52Z

❌ System test verification failed: link

im-konge · 2026-02-18T19:23:50Z

@strimzi/maintainers @OwenCorrigan76 what are we going to do with this PR? Should we split it into two PRs where in first we will cover everything except Bridge and in the second one we will cover Bridge? I think we should move this forward in some way.

ppatierno · 2026-02-19T13:53:05Z

From my perspective I would like to release the new bridge 0.34.0 with the 0.3.0 metrics reporter support, so I think this is still valid?

im-konge · 2026-02-19T13:58:36Z

From my perspective I would like to release the new bridge 0.34.0 with the 0.3.0 metrics reporter support, so I think this is still valid?

It is valid, but the question is if we should split it. If you will run the tests with new Bridge that has metrics-reporter 0.3.0, I think that the tests will anyway fail for the metrics-reporter, as the configuration is different.
That's why I said that we should split it into two implementation, where the Bridge part will be covered in PR updating Bridge to newer version.

im-konge · 2026-02-19T14:50:24Z

Or, we can have this PR only and change the Bridge image used in tests to the latest one. But I'm not sure what else it can break and if it's the right thing.

im-konge · 2026-02-27T21:45:19Z

So now when the 0.51.0 release is branched and we have RC1 (RC2 coming soon), we should move this forward. I'm still proposing the same -> removing the Bridge config from this PR, have this bump for everything else and when we have PR with new Bridge, changes needed for the metrics-reporter 0.3.0 will be added as part of it. WDYT @strimzi/maintainers ?

scholzj · 2026-02-27T21:54:14Z

So now when the 0.51.0 release is branched and we have RC1 (RC2 coming soon), we should move this forward. I'm still proposing the same -> removing the Bridge config from this PR, have this bump for everything else and when we have PR with new Bridge, changes needed for the metrics-reporter 0.3.0 will be added as part of it. WDYT @strimzi/maintainers ?

That seems reasonable.

ppatierno · 2026-02-28T05:58:39Z

Fine with me. Thanks.

im-konge · 2026-02-28T18:59:32Z

@OwenCorrigan76 could you please update this PR accordingly? Thanks

OwenCorrigan76 · 2026-03-03T09:27:14Z

Will do @im-konge. Thanks guys

scholzj · 2026-03-04T19:40:20Z

/gha run pipeline=regression

github-actions · 2026-03-04T19:40:56Z

⏳ System test verification started: link

The following 6 job(s) will be executed:

regression-brokers-and-security-amd64 (oracle-vm-8cpu-32gb-x86-64)
regression-operators-amd64 (oracle-vm-8cpu-32gb-x86-64)
regression-operands-amd64 (oracle-vm-8cpu-32gb-x86-64)
regression-brokers-and-security-arm64 (oracle-vm-8cpu-32gb-arm64)
regression-operators-arm64 (oracle-vm-8cpu-32gb-arm64)
regression-operands-arm64 (oracle-vm-8cpu-32gb-arm64)

Tests will start after successful build completion.

scholzj · 2026-03-04T19:40:56Z

docker-images/artifacts/kafka-thirdparty-libs/4.1.x/pom.xml

    <properties>
        <strimzi-oauth.version>0.17.1</strimzi-oauth.version>
-        <strimzi-metrics-reporter.version>0.2.0</strimzi-metrics-reporter.version>
+        <strimzi-metrics-reporter.version>0.3.0-rc1</strimzi-metrics-reporter.version>


It was released already, so should it be 0.3.0?

Thanks @scholzj. Updated

scholzj · 2026-03-04T19:41:04Z

docker-images/artifacts/kafka-thirdparty-libs/4.2.x/pom.xml

    <properties>
        <strimzi-oauth.version>0.17.1</strimzi-oauth.version>
-        <strimzi-metrics-reporter.version>0.2.0</strimzi-metrics-reporter.version>
+        <strimzi-metrics-reporter.version>0.3.0-rc1</strimzi-metrics-reporter.version>


Same as above.

github-actions · 2026-03-04T23:44:18Z

🎉 System test verification passed: link

Signed-off-by: ocorriga <ocorriga@redhat.com>

im-konge · 2026-03-05T13:37:01Z

/gha run pipeline=regression

github-actions · 2026-03-05T13:37:34Z

⏳ System test verification started: link

The following 6 job(s) will be executed:

regression-brokers-and-security-amd64 (oracle-vm-8cpu-32gb-x86-64)
regression-operators-amd64 (oracle-vm-8cpu-32gb-x86-64)
regression-operands-amd64 (oracle-vm-8cpu-32gb-x86-64)
regression-brokers-and-security-arm64 (oracle-vm-8cpu-32gb-arm64)
regression-operators-arm64 (oracle-vm-8cpu-32gb-arm64)
regression-operands-arm64 (oracle-vm-8cpu-32gb-arm64)

Tests will start after successful build completion.

github-actions · 2026-03-05T17:38:16Z

⚠️ System test verification skipped: link

im-konge · 2026-03-05T22:27:22Z

/gha run pipeline=regression

github-actions · 2026-03-05T22:27:57Z

⏳ System test verification started: link

The following 6 job(s) will be executed:

regression-brokers-and-security-amd64 (oracle-vm-8cpu-32gb-x86-64)
regression-operators-amd64 (oracle-vm-8cpu-32gb-x86-64)
regression-operands-amd64 (oracle-vm-8cpu-32gb-x86-64)
regression-brokers-and-security-arm64 (oracle-vm-8cpu-32gb-arm64)
regression-operators-arm64 (oracle-vm-8cpu-32gb-arm64)
regression-operands-arm64 (oracle-vm-8cpu-32gb-arm64)

Tests will start after successful build completion.

github-actions · 2026-03-06T03:45:48Z

🎉 System test verification passed: link

OwenCorrigan76 added this to the 0.51.0 milestone Feb 5, 2026

OwenCorrigan76 force-pushed the test_SMR-0.3.0 branch from 995ea0a to d1f311d Compare February 5, 2026 15:55

mimaison reviewed Feb 5, 2026

View reviewed changes

scholzj reviewed Feb 5, 2026

View reviewed changes

OwenCorrigan76 force-pushed the test_SMR-0.3.0 branch from d1f311d to 5ca3e96 Compare February 6, 2026 13:07

OwenCorrigan76 requested a review from im-konge February 6, 2026 14:44

im-konge marked this pull request as draft February 6, 2026 15:19

scholzj modified the milestones: 0.51.0, 0.52.0 Feb 24, 2026

OwenCorrigan76 force-pushed the test_SMR-0.3.0 branch from 5ca3e96 to c9bf55b Compare March 4, 2026 09:50

OwenCorrigan76 marked this pull request as ready for review March 4, 2026 11:14

OwenCorrigan76 requested review from mimaison and scholzj and removed request for mimaison March 4, 2026 11:15

OwenCorrigan76 requested review from im-konge, mimaison and scholzj and removed request for im-konge and scholzj March 4, 2026 11:23

scholzj reviewed Mar 4, 2026

View reviewed changes

ocorriga added 4 commits March 5, 2026 08:03

Update SMR to 0.3.0

99f897a

Signed-off-by: ocorriga <ocorriga@redhat.com>

Address comments

7457690

Signed-off-by: ocorriga <ocorriga@redhat.com>

Revert Metrics Reporter 0.3.0 update for Bridge

eef5363

Signed-off-by: ocorriga <ocorriga@redhat.com>

Remove rc-1 Metrics Reporter 0.3.0

aa5a887

Signed-off-by: ocorriga <ocorriga@redhat.com>

OwenCorrigan76 force-pushed the test_SMR-0.3.0 branch from c9bf55b to aa5a887 Compare March 5, 2026 09:00

im-konge approved these changes Mar 6, 2026

View reviewed changes

ppatierno approved these changes Mar 6, 2026

View reviewed changes

im-konge requested a review from scholzj March 6, 2026 17:00

scholzj approved these changes Mar 6, 2026

View reviewed changes

scholzj merged commit e8f9225 into strimzi:main Mar 6, 2026
32 checks passed

Conversation

OwenCorrigan76 commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Type of change

Description

Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Feb 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

im-konge commented Feb 6, 2026

Uh oh!

github-actions bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

im-konge commented Feb 6, 2026

Uh oh!

github-actions bot commented Feb 6, 2026

Uh oh!

im-konge commented Feb 6, 2026

Uh oh!

github-actions bot commented Feb 6, 2026

Uh oh!

im-konge commented Feb 18, 2026

Uh oh!

ppatierno commented Feb 19, 2026

Uh oh!

im-konge commented Feb 19, 2026

Uh oh!

im-konge commented Feb 19, 2026

Uh oh!

im-konge commented Feb 27, 2026

Uh oh!

scholzj commented Feb 27, 2026

Uh oh!

ppatierno commented Feb 28, 2026

Uh oh!

im-konge commented Feb 28, 2026

Uh oh!

OwenCorrigan76 commented Mar 3, 2026

Uh oh!

scholzj commented Mar 4, 2026

Uh oh!

github-actions bot commented Mar 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 4, 2026

Uh oh!

im-konge commented Mar 5, 2026

Uh oh!

github-actions bot commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 5, 2026

Uh oh!

im-konge commented Mar 5, 2026

Uh oh!

github-actions bot commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

OwenCorrigan76 commented Feb 5, 2026 •

edited

Loading

codecov bot commented Feb 5, 2026 •

edited

Loading

github-actions bot commented Feb 6, 2026 •

edited

Loading

github-actions bot commented Mar 4, 2026 •

edited

Loading

github-actions bot commented Mar 5, 2026 •

edited

Loading

github-actions bot commented Mar 5, 2026 •

edited

Loading