fix: align history package with react-router v5 requirements#263
Open
Jolg42 wants to merge 1 commit intostrichliste:masterfrom
Open
fix: align history package with react-router v5 requirements#263Jolg42 wants to merge 1 commit intostrichliste:masterfrom
Jolg42 wants to merge 1 commit intostrichliste:masterfrom
Conversation
Downgrade history from ^5.0.0 to ^4.10.1 to fix version mismatch. react-router v5 expects history v4 API (goBack/goForward), but history v5 renamed these methods (back/forward). This caused navigation failures. - Downgrade history to v4.10.1 (compatible with react-router v5) - Replace history.back() with history.goBack() in all components
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello :)
It's now my second PR, but first one in this frontend repo.
Description
Downgrade history from ^5.0.0 to ^4.10.1 to fix version mismatch.
Because react-router v5 expects history v4 API (goBack/goForward), but history v5 renamed these methods (back/forward). -> This caused navigation failures.
What this PR does
Notes:
yarn listshows the history version from react-router as^4.9.0which works with the version in this PR: