Conversation
|
I guess this makes sense. It's unfortunate, because in 95% of the cases this will be unnecessary, as most addons dont have manager helpers. |
ndelangen
left a comment
There was a problem hiding this comment.
I agree with @JReinhold that this is not needed in the vast majority of addons, and so we should optimize for those, and not add this.
In that case, we should likely remove The goal of adding it was to help users figure out a safe way to have manager code bundled without preview externals (which leads to hard-to-debug bugs when end users of the addon build Storybook). As externals have been streamlined, it's entirely possible this is no longer relevant in Storybook 10. And then if we can just mix up additional exports that get used in preview or manager, we might want to have entries just for that in the tsup config. We could call them Should we discuss this as the weekly triage? I feel we need to decide if we want the addon-kit to cover more use cases out of the box, or to cover the general case only. |
|
https://discord.com/channels/486522875931656193/1434050290956369931/1435868953095180338 is another example of addon where exposing DTS would help addon authors. |
See Sidnioulz/storybook-addon-tag-badges#124. It turns out we do need dts.
What I'm not sure about is if we expect any side effect from producing dts for manager itself.