Do not set absolute installation path#131
Open
volkm wants to merge 2 commits intostormchecker:masterfrom
Open
Conversation
Contributor
|
I am not sure this is better when not building via storm, but I dont care much about installing carl when not via storm. One could also disable this just for settings where this is not a toplevel project (using PROJECT_IS_TOP_LEVEL) Eitherway, looks good to merge ... |
Contributor
Author
|
I integrated your suggestion to only disable this when it is not the top level. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This led to carl being installed into a different directory than the rest of Storm.
This fixes one of the issues in stormchecker/storm#732