Skip to content

Conversation

@vojtechtrefny
Copy link
Member

Related: #1141

@gemini-code-assist
Copy link

Summary of Changes

Hello @vojtechtrefny, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the continuous integration setup for CentOS/RHEL 10 test runs. The change specifically targets the DNF Python bindings, ensuring that the system installs the python3-libdnf package rather than python3-libdnf5. This adjustment is crucial for maintaining compatibility and stability within the testing infrastructure on these particular operating system versions, preventing potential issues that might arise from using the DNF5 bindings.

Highlights

  • CI Configuration Update: The CI test plan for CentOS/RHEL 10 environments has been updated to install python3-libdnf instead of python3-libdnf5.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates the DNF Python bindings package for the RHEL-specific test plan. The change from python3-libdnf5 to python3-libdnf in plans/tests-rhel.fmf is appropriate for CentOS/RHEL 10. However, the fix appears to be incomplete as other test plans that might also run on RHEL/CentOS are not updated. Please see the specific comment for details.

how: shell
script:
- sudo dnf install -y python3-libdnf5 'dnf-command(copr)'
- sudo dnf install -y python3-libdnf 'dnf-command(copr)'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change correctly switches to python3-libdnf for this RHEL-specific test plan. However, the overall goal stated in the PR title, "Do not install DNF5 Python bindings on CentOS/RHEL 10", seems incompletely addressed. Other test plans, namely plans/blivet.fmf and plans/udisks.fmf, still reference python3-libdnf5. If these plans are intended to run on CentOS/RHEL 10, they will likely fail. To fully resolve the issue, please consider if those files need to be updated as well.

@vojtechtrefny vojtechtrefny merged commit 49608e3 into storaged-project:master Oct 31, 2025
45 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants