Enable multitenancy in Firebase.Auth project#218
Draft
GiampaoloGabba wants to merge 1 commit intostep-up-labs:masterfrom
Draft
Enable multitenancy in Firebase.Auth project#218GiampaoloGabba wants to merge 1 commit intostep-up-labs:masterfrom
GiampaoloGabba wants to merge 1 commit intostep-up-labs:masterfrom
Conversation
Collaborator
|
I had a quick look at the official firebase samples and they do not have the tentantId in their method signatures - instead they populate the tenantId in their version of our config object: I wonder if this solution would make the code more clean? By adding it to So in other words add the What do you think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm opening this draft to know if you are interested in support multitenancy.
I'have upated only the
Firebase.Authproject, i'm not using UI and also dont have the winui3 and uwp sdk installed.There are not "strict" breaking changes: the
tenantIdis an optional string. But even if its optional, people updating the nuget will be required to recompile their project (but this should not be a problem: if you are updating a nuget, then you'll likely recompile your project @ 😄 )Some additional tests will be required, but for now everything seems working great (already using it in my app without problems).
For reference, i took the requests that have the
tenantIdfield in input from here:https://developers.google.com/resources/api-libraries/documentation/identitytoolkit/v3/python/latest/identitytoolkit_v3.relyingparty.html#verifyAssertion
https://cloud.google.com/identity-platform/docs/use-rest-api?hl=it#section-confirm-email-verification