draft: Update DMM.yml: fix non-working Xpath#2620
Draft
Clasp8775 wants to merge 2 commits intostashapp:masterfrom
Draft
draft: Update DMM.yml: fix non-working Xpath#2620Clasp8775 wants to merge 2 commits intostashapp:masterfrom
Clasp8775 wants to merge 2 commits intostashapp:masterfrom
Conversation
Clasp8775
changed the title
| scene: | ||
| Title: //meta[@property="og:title"]/@content | ||
| Details: //td[@id="mu"]//div[@class="mg-b20 lh4"]/p[@class="mg-b20"]/text() | ||
| Details: /html/body/div[2]/main/div[3]/div[2]/div/div[2]/div[1]/div[2]/div/div[1]/text() |
Collaborator
There was a problem hiding this comment.
No. This is clearly copy-pasted from the browser selector path and is extremely inflexible
Contributor
Author
There was a problem hiding this comment.
Please wait with reviewing until after I've removed the draft status, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Examples to test
https://www.dmm.co.jp/mono/dvd/-/detail/=/cid=1drpt040/
Short description
I updated the Xpaths that were no longer working.
I can't get the URL scraper to work with URLs like https://video.dmm.co.jp/av/content/?id=1drpt00040, not sure why.