Skip to content

remove the program from PublicMemory when program_in_ppt=true#1725

Open
ohad-nir-starkware wants to merge 1 commit intoohadn/verify_program_builtin-without-extra-componentfrom
ohadn/remove_program_segment_from_proof-update
Open

remove the program from PublicMemory when program_in_ppt=true#1725
ohad-nir-starkware wants to merge 1 commit intoohadn/verify_program_builtin-without-extra-componentfrom
ohadn/remove_program_segment_from_proof-update

Conversation

@ohad-nir-starkware
Copy link
Copy Markdown
Collaborator

@ohad-nir-starkware ohad-nir-starkware commented Apr 4, 2026

Note

Medium Risk
Changes the proof/claim encoding and transcript mixing by conditionally omitting program memory and filtering public-memory lookups when program_in_ppt is enabled, which could break prover/verifier compatibility if any path still assumes the program is always present.

Overview
When program_in_ppt=true, the prover now omits the program from PublicMemory (making program an Option) and excludes program addresses from the public-memory lookup inputs to keep the lookup argument balanced.

Both the Rust and Cairo verifiers are updated to treat program memory as optional: program-length mixing uses 0 when absent, verify_program is skipped when None, and get_verification_output returns a default program_hash when no program section is provided. Golden proof JSON fixtures and tests are updated accordingly.

Reviewed by Cursor Bugbot for commit aa27de0. Bugbot is set up for automated code reviews on this repo. Configure here.


This change is Reviewable

@ohad-nir-starkware ohad-nir-starkware self-assigned this Apr 4, 2026
@ohad-nir-starkware ohad-nir-starkware force-pushed the ohadn/remove_program_segment_from_proof-update branch 2 times, most recently from 84042a3 to eea3391 Compare April 4, 2026 09:40
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit eea3391. Configure here.

@ohad-nir-starkware ohad-nir-starkware force-pushed the ohadn/remove_program_segment_from_proof-update branch 2 times, most recently from 6af6666 to 3ff3eb9 Compare April 4, 2026 10:52
@ohad-nir-starkware ohad-nir-starkware force-pushed the ohadn/verify_program_builtin-without-extra-component branch from 48615a5 to c955424 Compare April 5, 2026 16:55
@ohad-nir-starkware ohad-nir-starkware force-pushed the ohadn/remove_program_segment_from_proof-update branch from 3ff3eb9 to aa27de0 Compare April 5, 2026 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant