remove the program from PublicMemory when program_in_ppt=true#1725
Open
ohad-nir-starkware wants to merge 1 commit intoohadn/verify_program_builtin-without-extra-componentfrom
Conversation
84042a3 to
eea3391
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit eea3391. Configure here.
6af6666 to
3ff3eb9
Compare
48615a5 to
c955424
Compare
3ff3eb9 to
aa27de0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Changes the proof/claim encoding and transcript mixing by conditionally omitting program memory and filtering public-memory lookups when
program_in_pptis enabled, which could break prover/verifier compatibility if any path still assumes the program is always present.Overview
When
program_in_ppt=true, the prover now omits the program fromPublicMemory(makingprogramanOption) and excludes program addresses from the public-memory lookup inputs to keep the lookup argument balanced.Both the Rust and Cairo verifiers are updated to treat program memory as optional: program-length mixing uses
0when absent,verify_programis skipped whenNone, andget_verification_outputreturns a defaultprogram_hashwhen no program section is provided. Golden proof JSON fixtures and tests are updated accordingly.Reviewed by Cursor Bugbot for commit aa27de0. Bugbot is set up for automated code reviews on this repo. Configure here.
This change is