perf: avoid redundant String clones in doc parser#9307
Closed
Bashmunta wants to merge 1 commit intostarkware-libs:mainfrom
Closed
perf: avoid redundant String clones in doc parser#9307Bashmunta wants to merge 1 commit intostarkware-libs:mainfrom
Bashmunta wants to merge 1 commit intostarkware-libs:mainfrom
Conversation
orizi
requested changes
Dec 23, 2025
Collaborator
orizi
left a comment
There was a problem hiding this comment.
@orizi made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @Bashmunta).
crates/cairo-lang-doc/src/parser.rs line 219 at r1 (raw file):
_ => { let path = dest_url.clone().into_string(); let resolved_item = self.resolve_linked_item(item_id, &path);
this still alocates the string in the SmolStrId::from - so not really any better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change removes unnecessary String allocations when parsing documentation links. The link resolver now accepts &str instead of owning a String, and the CommentLinkToken Display implementation no longer clones its path field.
Type of change
Please check one:
Why is this change needed?
As a result, we reuse a single String instance per link and pass references into the resolver, keeping the behavior unchanged while reducing allocation overhead in the documentation parser.