Improve collection matching and upload options#176
Merged
ircwaves merged 32 commits intostac-utils:mainfrom Sep 17, 2025
Merged
Improve collection matching and upload options#176ircwaves merged 32 commits intostac-utils:mainfrom
ircwaves merged 32 commits intostac-utils:mainfrom
Conversation
- required either collection_matchers or legacy collection mapping to be non-empty. this is not backwards compatible as existing payloads do not require any collection matching/mapping configuration.
jkeifer
requested changes
Sep 15, 2025
jkeifer
approved these changes
Sep 16, 2025
Member
jkeifer
left a comment
There was a problem hiding this comment.
I left some comments that could result in changes if you so choose, but I am satisfied with the current state of everything (note: it was a bit hard to review all the changes because it looks like you pulled in a bunch of ruff rules that touched a lot of code 😅). Nothing I mentioned is really a deal breaker so do as you choose.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
uvand updates CI and pre-commit. It also makes some extensive changes and additions to the README, gets readthedocs working, and makes a minimal changeset to the readthedocs content.Related Issue(s):
Proposed Changes:
Payloadclass.collection_matchersarray to the payloadprocessblock. Mutually exclusive with the legacyprocess.upload_options.collectionsmap. This supports deterministic order in the pattern matching and directly supports a "catch_all" matcher, which is a common need.collection_optionsmap to the payloadprocessblock. Supports collection-specificupload_options, with a fallback to the globalprocess.upload_optionsif a collection is not found in the map.PR Checklist: