Skip to content

Handle configuration variables consistently with config.Settings() class#368

Merged
hrodmn merged 5 commits intostac-utils:mainfrom
mcucchi9:feature/config-variables
Mar 27, 2026
Merged

Handle configuration variables consistently with config.Settings() class#368
hrodmn merged 5 commits intostac-utils:mainfrom
mcucchi9:feature/config-variables

Conversation

@mcucchi9
Copy link
Copy Markdown
Contributor

@mcucchi9 mcucchi9 commented Mar 26, 2026

Related Issue(s):

Description:

This PR implements handling of ENABLE_TRANSACTIONS_EXTENSIONS, ENABLED_EXTENSIONS and UVICORN_ROOT_PATH environment configuration variables via the config.Settings class.

Closes #367

PR Checklist:

  • pre-commit hooks pass locally
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
  • Changes are added to the CHANGELOG.

Copy link
Copy Markdown
Collaborator

@hrodmn hrodmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mcucchi9! Looks good to me.

Copy link
Copy Markdown
Collaborator

@hrodmn hrodmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it would be good to add some new tests to tests/test_config.py to make sure the typical values for ENABLE_TRANSACTION_EXTENSIONS have the intended effect!

@mcucchi9
Copy link
Copy Markdown
Contributor Author

@hrodmn right, that makes sense. The backward compatibility should be ensured by how pydantic>2 handles the bool type (here), but it's better to add some tests.

@mcucchi9 mcucchi9 requested a review from hrodmn March 27, 2026 08:32
@hrodmn hrodmn merged commit 0cfb1ac into stac-utils:main Mar 27, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Include missing configuration variables in config.Settings class

2 participants