Handle configuration variables consistently with config.Settings() class#368
Merged
hrodmn merged 5 commits intostac-utils:mainfrom Mar 27, 2026
Merged
Conversation
hrodmn
requested changes
Mar 26, 2026
Collaborator
hrodmn
left a comment
There was a problem hiding this comment.
Actually, it would be good to add some new tests to tests/test_config.py to make sure the typical values for ENABLE_TRANSACTION_EXTENSIONS have the intended effect!
Contributor
Author
hrodmn
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue(s):
config.Settingsclass #367Description:
This PR implements handling of
ENABLE_TRANSACTIONS_EXTENSIONS,ENABLED_EXTENSIONSandUVICORN_ROOT_PATHenvironment configuration variables via theconfig.Settingsclass.Closes #367
PR Checklist:
pre-commithooks pass locallymake test)make docs)