Implement neq query operator#364
Conversation
bitner
left a comment
There was a problem hiding this comment.
This is fine, but I will note that this only works because pgstac tries to be very permissive on operators that it accepts, so it will take "ne", "neq", "<>", and "!=" to be the same thing in either a query, cql1 or cql2. This is technically incorrect, but we have decided it is better to be lax in what we accept.
Officially, pgstac only really tries to support CQL2 json and makes a good faith effort to support the query extension (which while not deprecated - for a while it actually was marked as deprecated, but it seems to have risen from the dead - does recommend people to switch to the filter extension with CQL2). It does this by trying to convert query or CQL1 into CQL2, but these transformations are far from fully tested in our unit tests.
It is highly recommended that people shift away from the query extension and from using CQL1 towards CQL2. At some point in the future it is likely that we will deprecate and cease support in pgstac for these.
Related Issue(s):
neqoperator is missing #363Description:
This PR does two things:
Operatorclass in theextensions/query.pymodule by removing the unusedoperatormethod and unnecessary dependencies.neqquery operator, leveraging theneqpgstacopeator, and add related test.Closes #363
PR Checklist:
pre-commithooks pass locallymake test)make docs)NOTE: tests have been run only for
pgstac=0.9.9, as per #346.