Open
Conversation
We can't name it to `QUERY` due to the case-insensitive file systems on MacOS and Window. Should we rename the annotation to `SEARCH` or something else?
Collaborator
|
You can write it in Kotlin where the file name doesn't need to match the class name. The case collision isn't a problem for people consuming the jar. |
Contributor
Author
|
I tried, grouped @MustBeDocumented
@Target(
AnnotationTarget.FUNCTION,
AnnotationTarget.PROPERTY_GETTER,
AnnotationTarget.PROPERTY_SETTER,
)
@Retention(AnnotationRetention.RUNTIME)
annotation class QUERY(
val value: String = ""
)
@MustBeDocumented
@Target(AnnotationTarget.VALUE_PARAMETER)
@Retention(AnnotationRetention.RUNTIME)
annotation class Query(
val value: String,
val encoded: Boolean = false,
)and ran |
Contributor
Author
|
We can't leave the single |
Contributor
Author
|
I added a new source set and moved the |
Collaborator
|
Ugh gotta do something for RoboVM |
Closed
1 task
Contributor
Author
|
I took a look at the RoboVM Gradle plugin and it doesn't seem to offer an easy way to support case-insensitive features. |
Collaborator
|
I'm just deleting it. It's time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can't name it toQUERYdue to the case-insensitive file systems on MacOS and Windows. Should we rename the annotation toSEARCHor something else?CHANGELOG.md's "Unreleased" section has been updated, if applicable.