Skip to content

Add a Jackson 3 converter#4552

Open
sschuberth wants to merge 2 commits intosquare:trunkfrom
sschuberth:jackson3-converter
Open

Add a Jackson 3 converter#4552
sschuberth wants to merge 2 commits intosquare:trunkfrom
sschuberth:jackson3-converter

Conversation

@sschuberth
Copy link
Copy Markdown

@sschuberth sschuberth commented Nov 5, 2025 •
edited
Loading

  • CHANGELOG.md's "Unreleased" section has been updated, if applicable.

@JakeWharton
Copy link
Copy Markdown
Collaborator

JakeWharton commented Nov 6, 2025

Thanks! This mostly looks good from a quick check.

I want to familiarize myself with this major release, but otherwise I hope to get this merged this month and released by EOY.

@sschuberth
Copy link
Copy Markdown
Author

sschuberth commented Nov 6, 2025

I ran ./gradlew spotlessApply to address the linter issues and squashed the formatting fixes into the last commit.

@sschuberth
Copy link
Copy Markdown
Author

sschuberth commented Nov 18, 2025

Mind approving the workflow once more to verify that tests now pass, @JakeWharton?

@sschuberth
Copy link
Copy Markdown
Author

sschuberth commented Dec 15, 2025

Mind approving the workflow once more to verify that tests now pass, @JakeWharton?

I've rebased this to catch-up with the new required final-status check, but now running checks needs an approval again.

@sschuberth sschuberth mentioned this pull request Dec 15, 2025
Draft
@sschuberth
Copy link
Copy Markdown
Author

sschuberth commented Dec 22, 2025

I hope to get this merged this month and released by EOY.

Is there still a chance to get this merged before the end of the year?

@sschuberth
Copy link
Copy Markdown
Author

sschuberth commented Jan 8, 2026

I hope to get this merged this month and released by EOY.

Is there still a chance to get this merged before the end of the year?

Happy new year ping 😉

@JakeWharton
Copy link
Copy Markdown
Collaborator

JakeWharton commented Jan 8, 2026

I have quit this company a few months ago so any work I do here is entirely volunteer work. I appreciate the contribution, but it'll still probably be a few weeks until I look at this project again.

@patschl
Copy link
Copy Markdown

patschl commented Jan 16, 2026

Hi! I'm also quite interested in this PR being merged. Is @JakeWharton the only maintainer of this project?

@JakeWharton
Copy link
Copy Markdown
Collaborator

JakeWharton commented Jan 17, 2026

The design of Retrofit is such that you do not need this to be merged to be unblocked. You can have your own Jackson 3 converter living in your codebase for the time being.

And yes, it's basically just me.

@chentianming11 chentianming11 mentioned this pull request Feb 12, 2026
Closed
@sschuberth sschuberth force-pushed the jackson3-converter branch from f6b073d to 5f64562 Compare March 6, 2026 16:13
@sschuberth
Add jackson-annotations as an explicit test dependency
5d6ab63 
This was implicitly available as a transitive dependency, but that
should not be relied on.

It is required for `JsonAutoDetect.Visibility.ANY`.

Note that `jackson-annotations` is versioned independently of the rest
of Jackson and does not use a path-level version suffix.
This was referenced Mar 11, 2026
Closed
Open
@sschuberth sschuberth force-pushed the jackson3-converter branch 2 times, most recently from 530062a to be1740e Compare March 12, 2026 11:52
@sschuberth
Add a converter for Jackson 3
8b481ce 
This mostly copies the existing Jackson (2) converter and does the
necessary migration [1]. Note that Jackson 3 requires Java 17.

[1]: https://github.com/FasterXML/jackson/blob/main/jackson3/MIGRATING_TO_JACKSON_3.md
danrebati-fujitsu
danrebati-fujitsu approved these changes Mar 12, 2026
View reviewed changes
Copy link
Copy Markdown

@danrebati-fujitsu danrebati-fujitsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though I am not a maintainer of this project. I'm just a passer-by 🙂

@sschuberth
Copy link
Copy Markdown
Author

sschuberth commented Mar 12, 2026

Looks good to me, though I am not a maintainer of this project. I'm just a passer-by 🙂

Thanks anyway for the review, you had some good findings there!

@joanvr
Copy link
Copy Markdown

joanvr commented Apr 15, 2026

when is this planned to get merged and released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@danrebati-fujitsu danrebati-fujitsu danrebati-fujitsu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sschuberth @JakeWharton @patschl @joanvr @danrebati-fujitsu