Check the Object from the serviceMethodCache again#4126
Open
Endeavour233 wants to merge 2 commits intosquare:trunkfrom
Open
Check the Object from the serviceMethodCache again#4126Endeavour233 wants to merge 2 commits intosquare:trunkfrom
Endeavour233 wants to merge 2 commits intosquare:trunkfrom
Conversation
Author
|
This resolves #4113 |
Author
|
Excuse me, do you have any plan about this PR? (I am good with closing it because it's intended to deal with a pretty extreme situation, and we can replace the whole method with |
Collaborator
|
I will get to it eventually, but probably not for a few weeks, unfortunately. Don't worry, it has been sitting in my notifications and won't get lost. |
Author
Thanks for your response. Then I'll leave it open. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wrote a test

annotationParsingFailureObservedByMultipleWaitingThreads()(modified from @JakeWharton 'sannotationParsingFailureObservedByWaitingThreads) inRetrofitTest.javato mock the situation I mentioned in #4114 . And I found that the code inbase:trunkbranch does failed the test and throw aClassCastException(3 failures out of 10 test attempts)This pull request tries to deal with this extreme situation. To verify it, I have ran the test case for 20 times and all succeeded.