Publish GoogleAutoConfiguration as auto-configuration class#113
Open
yankee42 wants to merge 1 commit intospring-social:masterfrom
Open
Publish GoogleAutoConfiguration as auto-configuration class#113yankee42 wants to merge 1 commit intospring-social:masterfrom
yankee42 wants to merge 1 commit intospring-social:masterfrom
Conversation
|
Would be great to have that in. Just took me an hour to even take into consideration that this might be missing... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the
GoogleAutoConfigurationis not automatically discovered. However auto configuration works when using@Import(GoogleAutoConfiguration.class). As far as I can tell this is because theorg.springframework.boot.autoconfigure.EnableAutoConfigurationproperty is not defined in the project. Originally it was defined in 7bd39f3 in the spring-social-google/src/main/java/META-INF/MANIFEST.MF, but this file seems to have been deleted.This PR attempts to bring back this config item.