Use existing token repository if present#19001
Open
indy5858 wants to merge 1 commit intospring-projects:mainfrom
Open
Use existing token repository if present#19001indy5858 wants to merge 1 commit intospring-projects:mainfrom
indy5858 wants to merge 1 commit intospring-projects:mainfrom
Conversation
do not overwrite repository set in production code; instead only wrap existing repository Closes spring-projectsgh-17082 Signed-off-by: Andre Kappes <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this PR prevents overwriting the repository set in production code. Instead it only wrap existing repository.
In this way, we avoid communicating tests; otherwise the csrf cookie is not returned in the GET request, once a test has run before that had a call to
with(csrf())to mock the CSRF token.I know that the tests are far from optimal with using a separate test class.
If there's a better way to make the test setup, please let me know
Closes #17082