Gh 18561 fix jackson date override #18582
Open
+17
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents NPE when GrantedAuthority.getAuthority() returns null. Closes spring-projectsgh-18543 Signed-off-by: Khyojae <khjae201@gmail.com>
Removed the forced enable of DateTimeFeature.WRITE_DATES_AS_TIMESTAMPS in CoreJacksonModule to prevent overriding user-defined Jackson settings. Added a regression test case in SecurityJacksonModulesTests to verify that dates are serialized as ISO strings when the feature is disabled. Signed-off-by: Khyojae <khjae201@gmail.com>
Signed-off-by: Khyojae <khjae201@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where
CoreJacksonModule(Jackson 3 version) forcibly enablesDateTimeFeature.WRITE_DATES_AS_TIMESTAMPS, overriding any user-defined configuration.Related Issue
Fixes #18561
Changes
enable(DateTimeFeature.WRITE_DATES_AS_TIMESTAMPS)fromCoreJacksonModule#setupModule.readDatesAsTimestampsIsDisabledThenSerializeAsIsoStringinSecurityJacksonModulesTests.Verification Results
Executed the added regression test and confirmed it passes after the fix (it fails without the fix).