Skip to content

Fixtests#2433

Open
Silverarmor wants to merge 3 commits intodevfrom
fixtests
Open

Fixtests#2433
Silverarmor wants to merge 3 commits intodevfrom
fixtests

Conversation

@Silverarmor
Copy link
Member

Failing tests:

FAILED tests/console/test_entry_point.py::test_download_song - assert 'Downloaded' in "Downloader settings: {'audio_providers': ['youtube-music'], 'lyrics_providers':\n['genius'], 'genius_token':                                             ...
FAILED tests/test_init.py::test_download - assert None not in (Song(name='Nobody Else', artists=['Abstrakt'], artist='Abstrakt', genres=[], disc_number=1, disc_count=1, album_name='Nobody Else', album_artist='Abstrakt', ...
FAILED tests/types/test_artist.py::test_artist_from_string - AssertionError: assert False

Warnings

tests/types/test_artist.py::test_artist_from_string
  C:\Programming\spotify-downloader\.venv\Lib\site-packages\spotipy\client.py:424: DeprecationWarning: You're using `artist_albums(..., album_type='...')` which will be removed in future versions. Please adjust your code accordingly by using `artist_albums(..., include_groups='...')` instead.
    warnings.warn(

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

@Silverarmor Silverarmor changed the base branch from master to dev August 8, 2025 04:25
@Silverarmor Silverarmor requested a review from Copilot August 8, 2025 04:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes failing tests by updating test cassettes and removing a dependency. The PR addresses three specific test failures related to Spotify API authentication and adds new HTTP interaction recordings.

  • Updated test cassettes to reflect current API responses and authentication tokens
  • Removed the vcrpy dependency from development dependencies
  • Added new HTTP interaction recordings for GitHub API calls and Spotify search functionality

Reviewed Changes

Copilot reviewed 8 out of 20 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/utils/cassettes/test_search/test_parse_yt_link.yaml Added new Spotify API interactions for track, artist, and album data
tests/utils/cassettes/test_search/test_parse_album_search.yaml Added album search interactions and track details for multiple songs
tests/utils/cassettes/test_github/test_get_status_fail.yaml Added failing GitHub API repository comparison interaction
tests/utils/cassettes/test_github/test_get_status.yaml Added successful GitHub API repository comparison with detailed response
tests/utils/cassettes/test_github/test_check_for_updates_fail.yaml Added failing GitHub releases API interaction
tests/types/cassettes/test_song/test_song_from_url.yaml Updated Spotify authentication tokens and API response data
pyproject.toml Removed vcrpy dependency from development requirements
Comments suppressed due to low confidence (1)

pyproject.toml:92

  • Removing the vcrpy dependency may break test recording functionality. Ensure that pytest-recording provides equivalent functionality or that tests no longer require VCR recording capabilities.
    "mkdocs-section-index>=0.3.5,<0.4",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants