Open
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes failing tests by updating test cassettes and removing a dependency. The PR addresses three specific test failures related to Spotify API authentication and adds new HTTP interaction recordings.
- Updated test cassettes to reflect current API responses and authentication tokens
- Removed the
vcrpydependency from development dependencies - Added new HTTP interaction recordings for GitHub API calls and Spotify search functionality
Reviewed Changes
Copilot reviewed 8 out of 20 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/utils/cassettes/test_search/test_parse_yt_link.yaml | Added new Spotify API interactions for track, artist, and album data |
| tests/utils/cassettes/test_search/test_parse_album_search.yaml | Added album search interactions and track details for multiple songs |
| tests/utils/cassettes/test_github/test_get_status_fail.yaml | Added failing GitHub API repository comparison interaction |
| tests/utils/cassettes/test_github/test_get_status.yaml | Added successful GitHub API repository comparison with detailed response |
| tests/utils/cassettes/test_github/test_check_for_updates_fail.yaml | Added failing GitHub releases API interaction |
| tests/types/cassettes/test_song/test_song_from_url.yaml | Updated Spotify authentication tokens and API response data |
| pyproject.toml | Removed vcrpy dependency from development requirements |
Comments suppressed due to low confidence (1)
pyproject.toml:92
- Removing the vcrpy dependency may break test recording functionality. Ensure that pytest-recording provides equivalent functionality or that tests no longer require VCR recording capabilities.
"mkdocs-section-index>=0.3.5,<0.4",
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Failing tests:
Warnings