bug fix, although I cannot tell how this ever worked, so really I jus…#278
Open
jmordkoff wants to merge 3 commits intospookylukey:masterfrom
Open
bug fix, although I cannot tell how this ever worked, so really I jus…#278jmordkoff wants to merge 3 commits intospookylukey:masterfrom
jmordkoff wants to merge 3 commits intospookylukey:masterfrom
Conversation
…t want to start the discussion
Owner
|
Looks like it was removed here: django/django@129583a#diff-5a7bf4b2271ba7a2dcce4b0bbef40199985f02cbce6aeebf2111401c2342d57b As you can see, there is a Are you actually using it? If not, my preference is to simply remove this code. If you are, then I require a test to be added that covers any code that will be changed. The test must fail without the changes, and pass with them. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…t want to start the discussion.
As far as I can tell, forms.fields has never had a member call EMPTY_VALUES. There is empty_values, and there is django.core.validators.EMPTY_VALUES. So how did this code ever work?