Conversation
There was a problem hiding this comment.
Pull request overview
This pull request adds documentation for setting up blocklog monitoring and updates Grafana documentation structure. The PR title translates to "Added blocklog setup instructions."
Changes:
- Added new documentation for Midnight-blocklog setup and usage
- Updated Grafana documentation frontmatter to follow standard format
- Added category configuration for Testnet-02 documentation section
- Added placeholder documentation for Docker Airgap updates
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
docs/docs/midnight/testnet-02/setup-grafana.md |
Updated frontmatter to use sidebar_position instead of position and refined title/description |
docs/docs/midnight/testnet-02/blocklog.md |
New documentation for installing and using Midnight-blocklog tool with Rust installation, build instructions, and usage examples |
docs/docs/midnight/testnet-02/_category_.json |
New category configuration file for Testnet-02 documentation section |
docs/docs/airgap/docker/update-airgap.md |
New documentation file with placeholder headings for Docker Airgap update procedures |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,32 @@ | |||
| --- | |||
| title: Docker Airgap のアップデート | |||
| description: Docker Airgap のアップデート方法について | |||
There was a problem hiding this comment.
The frontmatter is missing the sidebar_position property. All other documentation files in this directory have this property set (about.md uses 1, install-docker-desktop.md uses 2, setup-airgap.md uses 3, setup-ctool.md uses 4). Consider adding an appropriate sidebar_position value, such as 5, to maintain consistency with other files in the directory.
| description: Docker Airgap のアップデート方法について | |
| description: Docker Airgap のアップデート方法について | |
| sidebar_position: 5 |
| git clone https://github.com/btbf/Midnight-blocklog.git | ||
| cd Midnight-blocklog | ||
| git checkout 0.3.2 | ||
| cargo install --path . --bin mblog --locked --force |
There was a problem hiding this comment.
This documentation instructs operators to git clone a third-party repository (btbf/Midnight-blocklog), check out a mutable tag (0.3.2), and run cargo install on it, which effectively executes unverified code that will later be given access to the node's keystore via --keystore-path. If the GitHub account or tag is compromised, or the repository is maliciously modified, operators could transparently install a backdoored mblog binary that exfiltrates private keys or tampers with monitoring data. To reduce this supply chain risk, pin installation to an immutable identifier (e.g., a specific commit or release checksum) and/or require operators to verify signatures or checksums from a trusted source before building and installing the tool.
No description provided.