Exclude Protobuf generation from "all" target #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Protobuf generation does not need to happen during a regular build. This is only necessary when proto changes and that is very rare and can be run manually when needed. Re-generation during "all" target currently causes the generated files to be updated unpredictably if the locally installed version of protoc is different. In the future we will want to fix this by using a fixed version of protoc tools.
Benchmark ResultBenchmark diff with base branchBenchmark result |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protobuf generation does not need to happen during a regular build. This is only necessary when proto changes and that is very rare and can be run manually when needed.
Re-generation during "all" target currently causes the generated files to be updated unpredictably if the locally installed version of protoc is different. In the future we will want to fix this by using a fixed version of protoc tools.