Draft
Conversation
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
kfox1111
requested review from
MarcosDY,
amartinezfayo,
evan2645,
rturner3 and
sorindumitru
as code owners
Signed-off-by: Kevin Fox <Kevin.Fox@pnnl.gov>
|
|
||
| func (c *agentConfig) getAddr() (net.Addr, error) { | ||
| return util.GetUnixAddrWithAbsPath(c.SocketPath) | ||
| resolved := common.ResolveSocketPath(c.SocketPath, common.DefaultSocketPath, "SPIFFE_PUBLIC_SOCKET_TEMPLATE", c.Instance) |
Collaborator
There was a problem hiding this comment.
I think this variable should be SPIRE_PUBLIC_SOCKET_TEMPLATE. We can't use anything from the SPIFFE_ namespace since the spec might want to use that later on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request check list
Description of change
Adds easy multiinstance support
Which issue this PR fixes
fixes #6247