Open
Conversation
cyclinder
force-pushed
the
dra/v1beta1
branch
4 times, most recently
from
0ddd782 to
e1b8583
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4695 +/- ##
==========================================
- Coverage 75.27% 74.27% -1.00%
==========================================
Files 56 56
Lines 6770 6861 +91
==========================================
Hits 5096 5096
- Misses 1461 1552 +91
Partials 213 213
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
cyclinder
force-pushed
the
dra/v1beta1
branch
4 times, most recently
from
0c95492 to
5e72b02
Compare
weizhoublue
reviewed
Mar 26, 2025
| mountPath: /var/run/netns | ||
| mountPropagation: Bidirectional | ||
| {{- end }} | ||
| {{- if .Values.spiderpoolAgent.dra.enabled }} |
Collaborator
There was a problem hiding this comment.
这个建议不要做这个判断，而是默认就是要加载，因为 开关由 configmap 中决定，否则功能的 使能 就不是简单 设置 configmap，而是要 helm upgrade 。那么 configmap 中的 开关作用 就不大了
这里 理想的是 应该是要 通过 helm 检测 k8s ablitiy dra ，来决定是否加载
cyclinder
changed the title
cyclinder
force-pushed
the
dra/v1beta1
branch
9 times, most recently
from
4378480 to
4516eaa
Compare
cyclinder
force-pushed
the
dra/v1beta1
branch
6 times, most recently
from
5a79125 to
65fdabf
Compare
Signed-off-by: Cyclinder Kuo <kuocyclinder@gmail.com>
Signed-off-by: Cyclinder Kuo <kuocyclinder@gmail.com>
Signed-off-by: Cyclinder Kuo <kuocyclinder@gmail.com>
Signed-off-by: Cyclinder Kuo <kuocyclinder@gmail.com>
Signed-off-by: Cyclinder Kuo <kuocyclinder@gmail.com>
Signed-off-by: Cyclinder Kuo <kuocyclinder@gmail.com>
Signed-off-by: Cyclinder Kuo <kuocyclinder@gmail.com>
Signed-off-by: Cyclinder Kuo <kuocyclinder@gmail.com>
Signed-off-by: Cyclinder Kuo <kuocyclinder@gmail.com>
Signed-off-by: Cyclinder Kuo <kuocyclinder@gmail.com>
Signed-off-by: Cyclinder Kuo <kuocyclinder@gmail.com>
Signed-off-by: Cyclinder Kuo <kuocyclinder@gmail.com>
Signed-off-by: Cyclinder Kuo <kuocyclinder@gmail.com>
Signed-off-by: Cyclinder Kuo <qifeng.guo@daocloud.io>
cyclinder
force-pushed
the
dra/v1beta1
branch
from
3442cff to
60a60c8
Compare
cyclinder
changed the title
Contributor
|
This pull request has been automatically marked as stale because it |
github-actions
bot
added
pr/stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing!
Notice:
"release/none"
"release/bug"
"release/feature"
What issue(s) does this PR fix:
Fixes #
Special notes for your reviewer: