chore(deps-dev): bump eslint from 8.57.1 to 9.32.0#5030
chore(deps-dev): bump eslint from 8.57.1 to 9.32.0#5030marcoscaceres wants to merge 1 commit intomainfrom
Conversation
✅ Deploy Preview for respec-pr ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
marcoscaceres
force-pushed
the
eslint_updgrade
branch
from
d5a195a to
19315bb
Compare
marcoscaceres
requested review from
Copilot and
sidvishnoi
and removed request for
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR updates ESLint from version 8.57.1 to 9.32.0, which is a major version upgrade requiring migration from the legacy .eslintrc.json configuration to the new flat configuration format (eslint.config.mjs).
- Migrates from legacy ESLint configuration format to the new flat config system
- Removes unnecessary ESLint disable comments that are no longer needed with the new version
- Fixes a logical bug in the
before-save.jsfile where the||operator was incorrectly used
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updates ESLint to v9.32.0 and adds required compatibility packages |
| eslint.config.mjs | New flat configuration file replacing the legacy .eslintrc.json |
| .eslintrc.json | Removes the legacy ESLint configuration file |
| src/core/before-save.js | Fixes logical operator bug from ` |
| tests/support-files/hljs-testlang.js | Removes unnecessary eslint-disable comment |
| tests/spec/core/webidl-spec.js | Removes unnecessary eslint-disable comments |
| tests/spec/SpecHelper.js | Removes unnecessary eslint-disable comment |
| src/w3c/templates/sotd.js | Removes unnecessary eslint-disable comment |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
| }); | ||
|
|
||
| export default defineConfig([ | ||
| globalIgnores(["builds/**/*", "js/**/*", "tests/**/*", "eslint.config.mjs"]), |
There was a problem hiding this comment.
In ESLint flat config, global ignores should be specified using the ignores property in a configuration object, not as a function call. The correct format would be: { ignores: ["builds/**/*", "js/**/*", "tests/**/*", "eslint.config.mjs"] }
| globalIgnores(["builds/**/*", "js/**/*", "tests/**/*", "eslint.config.mjs"]), | |
| { ignores: ["builds/**/*", "js/**/*", "tests/**/*", "eslint.config.mjs"] }, |
| "eslint:recommended", | ||
| "plugin:prettier/recommended" | ||
| ), | ||
|
|
There was a problem hiding this comment.
The extends property is not valid in ESLint flat config. The compat.extends() result should be spread directly into the configuration array using the spread operator: ...compat.extends(...)
| ...compat.extends( | |
| "eslint:recommended", | |
| "plugin:prettier/recommended" | |
| ), | |
| { |
1 participant
Closes #5018