Add GoLang support for benchmarks#247
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
2b6b2f0 to
b423937
Compare
b641711 to
ff6d40d
Compare
| && chmod +x /usr/local/bin/gosu | ||
|
|
||
| # Download and install Go | ||
| RUN wget -q "https://go.dev/dl/go${GO_VERSION}.linux-${TARGETARCH}.tar.gz" -O go.tar.gz && \ |
There was a problem hiding this comment.
If the base image is amazon/aws-lambda-go:1.2024.10.04.19, then do we need to install Go separately?
|
|
||
| cd /mnt/function | ||
| go mod init github.com/spcl/serverless-benchmarks | ||
| go get github.com/minio/minio-go/v7 |
There was a problem hiding this comment.
We only need that for the local deployment—this should be installed as a "storage" module; see the example for Python. Depending on the enabled storage options and the cloud system, these packages should be added during deployment. In case of Python, we append new packages to requirements.txt - https://github.com/spcl/serverless-benchmarks/blob/master/sebs/benchmark.py#L361
| #!/bin/bash | ||
|
|
||
| cd /mnt/function | ||
| go mod init github.com/spcl/serverless-benchmarks |
| json.dump(package_json, package_file, indent=2) | ||
|
|
||
| def add_deployment_package_golang(self, output_dir): | ||
| pass |
There was a problem hiding this comment.
Here we should add system-dependent packages :)
supported_language_versionsfunction.golang_installer.sh