Fix Example 1 documentation: pipeline() returns numpy array, not dict#456
Open
Tao-Yida wants to merge 1 commit intosparkfish:devfrom
Open
Fix Example 1 documentation: pipeline() returns numpy array, not dict#456Tao-Yida wants to merge 1 commit intosparkfish:devfrom
Tao-Yida wants to merge 1 commit intosparkfish:devfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes incorrect documentation in Example 1 that would cause an IndexError when users run the code. The documentation incorrectly showed that pipeline(image) returns a dictionary, when it actually returns a numpy array directly.
Changes:
- Updated Example 1 to show two correct ways of using the pipeline: calling
pipeline(image)to get a numpy array directly, and callingpipeline.augment(image, return_dict=1)to explicitly request a dictionary
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example 1 in the documentation (https://augraphy.readthedocs.io/en/latest/doc/source/example_usage.html) contains incorrect code that causes an
IndexErrorwhen users try to run it.The current code shows:
ruturns:
But pipeline(image) returns a numpy array directly (via
__call__method which callsaugment(image, return_dict=0)), not a dictionary.In
AugraphyPipeline.__call__:When
return_dict=0, the augment method returnsdata["output"](numpy array), not the full dictionary.