Skip to content

Conversation

@nolta
Copy link
Contributor

@nolta nolta commented Jan 23, 2026

This series of commits for vasp:

  • adds versions 6.3.1 & 6.4.2;
  • adds variants for libbeef, libxc, & wannier90 support;
  • adds a new libbeef package.

@nolta
Copy link
Contributor Author

nolta commented Jan 23, 2026

@spackbot fix style

@spackbot-app
Copy link

spackbot-app bot commented Jan 23, 2026

Let me see if I can fix that for you!

@spackbot-app
Copy link

spackbot-app bot commented Jan 23, 2026

I was able to run spack style --fix for you!

spack style --fix
repos/spack_repo/builtin/packages/libbeef/package.py
repos/spack_repo/builtin/packages/vasp/package.py
�[1;34m==> �[0mrunning flake8
repos/spack_repo/builtin/packages/libbeef/package.py:30: [W391] blank line at end of file
�[1;34m==> �[0mrunning isort
�[1;34m==> �[0mrunning black
Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I've updated the branch with style fixes.

But it looks like I'm not able to push to your branch. 😭️ Did you check Allow edits from maintainers when you opened the PR?

@nolta nolta force-pushed the pr-vasp-libbeef-libxc-wannier90 branch from 7fd0814 to 49e8529 Compare January 23, 2026 19:31
@nolta
Copy link
Contributor Author

nolta commented Jan 23, 2026

@snehring

@snehring
Copy link
Contributor

The changes look fine to me. I don't have the vasp versions that are added on hand so I can't validate the checksums directly. 6.5.1 compiles with the added changes.

Copy link
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the homepage and version commit (libbeef); can't verify vasp since manual download.

@tldahlgren tldahlgren merged commit cfbf7ae into spack:develop Jan 27, 2026
17 checks passed
@tldahlgren tldahlgren self-assigned this Jan 27, 2026
@nolta nolta deleted the pr-vasp-libbeef-libxc-wannier90 branch January 27, 2026 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants