fix(core): update tests and examples to match Core API signature#3016
Open
StarbirdTech wants to merge 2 commits intospacedriveapp:mainfrom
Open
fix(core): update tests and examples to match Core API signature#3016StarbirdTech wants to merge 2 commits intospacedriveapp:mainfrom
StarbirdTech wants to merge 2 commits intospacedriveapp:mainfrom
Conversation
Core::new() and Core::shutdown() return Box<dyn Error + Send + Sync> but tests/examples still used Box<dyn Error>, causing compilation failures. Also fix stale schema in library_demo (entry.device_id was replaced with volume_id, location now requires volume_id field) and remove unused uuid import in job_registration_test. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: tembo[bot] <208362400+tembo[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core::new()andCore::shutdown()were updated to returnBox<dyn Error + Send + Sync>, but several tests and examples still useBox<dyn Error>, preventingcargo test -p sd-corefrom compiling.Changes
Box<dyn Error>toBox<dyn Error + Send + Sync>library_demo.rs—entry.device_idwas removed (nowvolume_id),locationneedsvolume_idfielduuid::Uuidimport injob_registration_test.rsFiles changed
core/tests/phase_snapshot_test.rscore/tests/event_system_test.rscore/tests/job_registration_test.rscore/examples/library_demo.rscore/examples/shutdown_demo.rscore/examples/indexing_demo.rscore/examples/job_logging_test.rsTest plan
cargo check --tests --examples -p sd-corecompilescargo test -p sd-corepasses🤖 Generated with Claude Code