Skip to content

fix(core): update tests and examples to match Core API signature#3016

Open
StarbirdTech wants to merge 2 commits intospacedriveapp:mainfrom
StarbirdTech:fix/core-test-error-types
Open

fix(core): update tests and examples to match Core API signature#3016
StarbirdTech wants to merge 2 commits intospacedriveapp:mainfrom
StarbirdTech:fix/core-test-error-types

Conversation

@StarbirdTech
Copy link
Contributor

@StarbirdTech StarbirdTech commented Feb 6, 2026

Note: This was identified by Claude Code during work on #2988 — I haven't personally reviewed these changes yet. The fixes are mechanical (type signature updates) but flagging for maintainer review.

Core::new() and Core::shutdown() were updated to return Box<dyn Error + Send + Sync>, but several tests and examples still use Box<dyn Error>, preventing cargo test -p sd-core from compiling.

Changes

  • Update return types in 5 test/example files from Box<dyn Error> to Box<dyn Error + Send + Sync>
  • Fix stale schema in library_demo.rsentry.device_id was removed (now volume_id), location needs volume_id field
  • Remove unused uuid::Uuid import in job_registration_test.rs

Files changed

  • core/tests/phase_snapshot_test.rs
  • core/tests/event_system_test.rs
  • core/tests/job_registration_test.rs
  • core/examples/library_demo.rs
  • core/examples/shutdown_demo.rs
  • core/examples/indexing_demo.rs
  • core/examples/job_logging_test.rs

Test plan

  • cargo check --tests --examples -p sd-core compiles
  • cargo test -p sd-core passes

🤖 Generated with Claude Code

Core::new() and Core::shutdown() return Box<dyn Error + Send + Sync>
but tests/examples still used Box<dyn Error>, causing compilation
failures. Also fix stale schema in library_demo (entry.device_id was
replaced with volume_id, location now requires volume_id field) and
remove unused uuid import in job_registration_test.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: tembo[bot] <208362400+tembo[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant