Fix various URI resolution bugs by jviotti · Pull Request #2278 · sourcemeta/core

jviotti · 2026-02-27T19:44:41Z

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

cubic-dev-ai

No issues found across 2 files

augmentcode · 2026-02-27T19:47:10Z

🤖 Augment PR Summary

Summary: Fixes a bug in URI::relative_to where URIs could be made relative even when their authority ports differ.

Changes:

Adds an explicit port equality check when deciding whether a URI can be made relative to a base
Adds a regression test ensuring different ports keep the URI absolute

_{🤖 Was this summary useful? React with 👍 or 👎}

augmentcode

Review completed. 1 suggestions posted.

Comment augment review to trigger a new review at any time.

augmentcode · 2026-02-27T19:47:23Z

src/core/uri/resolution.cc

  }

+  // Ports must match (but both can be null)
+  if (this->port_ != base.port_) {


relative_to() now checks host_/port_, but it can still incorrectly make a URI relative when userinfo_ differs (the method resets userinfo_, so resolving the result against base won’t round-trip to the original URI). Consider also requiring userinfo_ to match before stripping authority components.

Severity: medium

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

github-actions

Benchmark (linux/llvm)

Details

Benchmark suite	Current: `f36ec16`	Previous: `d2bc5b7`	Ratio
`Regex_Lower_S_Or_Upper_S_Asterisk`	`3.1622883489714284` ns/iter	`3.1182801453367683` ns/iter	`1.01`
`Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar`	`3.110342192281956` ns/iter	`3.112282648581244` ns/iter	`1.00`
`Regex_Period_Asterisk`	`3.1118278396431656` ns/iter	`3.111719142408526` ns/iter	`1.00`
`Regex_Group_Period_Asterisk_Group`	`3.110925506507451` ns/iter	`3.113022428863955` ns/iter	`1.00`
`Regex_Period_Plus`	`2.8854094781238917` ns/iter	`3.1195702821445144` ns/iter	`0.92`
`Regex_Period`	`3.1105572230330676` ns/iter	`3.1141450028507145` ns/iter	`1.00`
`Regex_Caret_Period_Plus_Dollar`	`3.1127337593953635` ns/iter	`3.1202639092387403` ns/iter	`1.00`
`Regex_Caret_Group_Period_Plus_Group_Dollar`	`2.893252350429325` ns/iter	`3.1156833894263083` ns/iter	`0.93`
`Regex_Caret_Period_Asterisk_Dollar`	`3.7317828792767433` ns/iter	`3.733918433505426` ns/iter	`1.00`
`Regex_Caret_Group_Period_Asterisk_Group_Dollar`	`3.7492384458135204` ns/iter	`3.7314299854776034` ns/iter	`1.00`
`Regex_Caret_X_Hyphen`	`10.280664657613725` ns/iter	`13.060919009352153` ns/iter	`0.79`
`Regex_Period_Md_Dollar`	`28.75397645318229` ns/iter	`28.765979654086134` ns/iter	`1.00`
`Regex_Caret_Slash_Period_Asterisk`	`7.485788664603194` ns/iter	`6.541401070998198` ns/iter	`1.14`
`Regex_Caret_Period_Range_Dollar`	`4.04484476650391` ns/iter	`4.045588511281111` ns/iter	`1.00`
`Regex_Nested_Backtrack`	`49.89170978685863` ns/iter	`50.43654188754919` ns/iter	`0.99`
`JSON_Array_Of_Objects_Unique`	`438.24107576188914` ns/iter	`438.5844168564995` ns/iter	`1.00`
`JSON_Parse_1`	`6448.789986255269` ns/iter	`6368.072295989759` ns/iter	`1.01`
`JSON_Parse_Real`	`11242.695114697957` ns/iter	`11231.400047355699` ns/iter	`1.00`
`JSON_Parse_Decimal`	`12219.356873888957` ns/iter	`11858.78601460676` ns/iter	`1.03`
`JSON_Parse_Schema_ISO_Language`	`3648609.369791463` ns/iter	`3649530.7905748747` ns/iter	`1.00`
`JSON_Fast_Hash_Helm_Chart_Lock`	`61.98900674624898` ns/iter	`61.58323633021638` ns/iter	`1.01`
`JSON_Equality_Helm_Chart_Lock`	`179.68778576181356` ns/iter	`177.9617462204751` ns/iter	`1.01`
`JSON_Divisible_By_Decimal`	`599.9781321106628` ns/iter	`591.309000523793` ns/iter	`1.01`
`JSON_String_Equal/10`	`6.538362726142455` ns/iter	`6.540199470207802` ns/iter	`1.00`
`JSON_String_Equal/100`	`7.159374014407857` ns/iter	`7.312955362014221` ns/iter	`0.98`
`JSON_String_Equal_Small_By_Perfect_Hash/10`	`0.9352502698913686` ns/iter	`0.9370553317437403` ns/iter	`1.00`
`JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10`	`10.264435075028778` ns/iter	`14.61197608854238` ns/iter	`0.70`
`JSON_String_Fast_Hash/10`	`2.800167305359042` ns/iter	`2.8076787867393556` ns/iter	`1.00`
`JSON_String_Fast_Hash/100`	`2.799185402053369` ns/iter	`2.8006340526556417` ns/iter	`1.00`
`JSON_String_Key_Hash/10`	`2.182047323501726` ns/iter	`2.641736869766993` ns/iter	`0.83`
`JSON_String_Key_Hash/100`	`6.7398618140862405` ns/iter	`9.020938431933475` ns/iter	`0.75`
`JSON_Object_Defines_Miss_Same_Length`	`3.747667136174652` ns/iter	`3.73898332561015` ns/iter	`1.00`
`JSON_Object_Defines_Miss_Too_Small`	`3.736192162856395` ns/iter	`3.738687416180984` ns/iter	`1.00`
`JSON_Object_Defines_Miss_Too_Large`	`3.7519380851215645` ns/iter	`3.7377910141406283` ns/iter	`1.00`
`Pointer_Object_Traverse`	`45.08597358145009` ns/iter	`44.424855914856735` ns/iter	`1.01`
`Pointer_Object_Try_Traverse`	`53.55137459225681` ns/iter	`53.58565847831887` ns/iter	`1.00`
`Pointer_Push_Back_Pointer_To_Weak_Pointer`	`437.83322948724623` ns/iter	`303.0745980718229` ns/iter	`1.44`
`Pointer_Walker_Schema_ISO_Language`	`3132230.9111111383` ns/iter	`3178604.149321489` ns/iter	`0.99`
`Schema_Frame_WoT_References`	`4850014.652777506` ns/iter	`4800209.767123082` ns/iter	`1.01`
`Schema_Frame_OMC_References`	`20145791.65714362` ns/iter	`19846598.14285936` ns/iter	`1.02`
`Schema_Frame_OMC_Locations`	`18466694.605263602` ns/iter	`18261925.947369587` ns/iter	`1.01`
`Schema_Frame_ISO_Language_Locations`	`101261436.33332656` ns/iter	`97479878.33331233` ns/iter	`1.04`
`Schema_Frame_KrakenD_References`	`37897087.052634135` ns/iter	`36605929.21052117` ns/iter	`1.04`
`Schema_Frame_KrakenD_Reachable`	`556883859.0000951` ns/iter	`563898385.9998916` ns/iter	`0.99`
`Schema_Iterator_ISO_Language`	`2301535.4721311554` ns/iter	`2319500.7384105194` ns/iter	`0.99`
`Schema_Frame_ISO_Language_Locations_To_JSON`	`131642360.7499928` ns/iter	`129960819.75001061` ns/iter	`1.01`
`Schema_Tracker_ISO_Language`	`27318606.608698405` ns/iter	`27513707.75999931` ns/iter	`0.99`
`Schema_Tracker_ISO_Language_To_JSON`	`24441117.96428875` ns/iter	`22227572.250002936` ns/iter	`1.10`
`Schema_Format_ISO_Language_To_JSON`	`107255797.57146469` ns/iter	`102821419.99998982` ns/iter	`1.04`
`Schema_Bundle_Meta_2020_12`	`1662624.9976075978` ns/iter	`1652998.6014172921` ns/iter	`1.01`
`Schema_Frame_Many_Resources_References`	`361228208` ns/iter	`350048989.5000101` ns/iter	`1.03`
`Alterschema_Check_Readibility_ISO_Language_Set_3`	`219279485.3333453` ns/iter	`208875631.66669074` ns/iter	`1.05`
`Alterschema_Check_Readibility_OMC`	`33345401.04761648` ns/iter	`31967794.227274347` ns/iter	`1.04`
`Alterschema_Apply_Readibility_KrakenD`	`594823625.0000036` ns/iter	`577144450.9998673` ns/iter	`1.03`
`EditorSchema_ForEditor_EmbeddedResources`	`13565700.730778802` ns/iter	`13470658.038460651` ns/iter	`1.01`
`URITemplateRouter_Create`	`16850.86017907602` ns/iter	`16757.987618233114` ns/iter	`1.01`
`URITemplateRouter_Match`	`184.27019886615687` ns/iter	`175.72671262624098` ns/iter	`1.05`
`URITemplateRouterView_Restore`	`6850.094455932856` ns/iter	`7039.889696618701` ns/iter	`0.97`
`URITemplateRouterView_Match`	`147.70596390743228` ns/iter	`145.91358498627943` ns/iter	`1.01`

This comment was automatically generated by workflow using github-action-benchmark.

github-actions

Benchmark (macos/llvm)

Details

Benchmark suite	Current: `f36ec16`	Previous: `d2bc5b7`	Ratio
`Regex_Lower_S_Or_Upper_S_Asterisk`	`1.7095658325977072` ns/iter	`1.7724624480120728` ns/iter	`0.96`
`Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar`	`1.6716952890680168` ns/iter	`1.647800266119304` ns/iter	`1.01`
`Regex_Period_Asterisk`	`1.7166133724318213` ns/iter	`1.724044261970107` ns/iter	`1.00`
`Regex_Group_Period_Asterisk_Group`	`1.7018010990684893` ns/iter	`1.7135830009260546` ns/iter	`0.99`
`Regex_Period_Plus`	`2.0531288399962033` ns/iter	`2.1329603742586274` ns/iter	`0.96`
`Regex_Period`	`2.166768894860085` ns/iter	`2.214630976805166` ns/iter	`0.98`
`Regex_Caret_Period_Plus_Dollar`	`2.1142768962757446` ns/iter	`2.069987299845473` ns/iter	`1.02`
`Regex_Caret_Group_Period_Plus_Group_Dollar`	`2.2906079304803355` ns/iter	`2.5842583169700593` ns/iter	`0.89`
`Regex_Caret_Period_Asterisk_Dollar`	`1.9410228123864854` ns/iter	`1.8782372540007137` ns/iter	`1.03`
`Regex_Caret_Group_Period_Asterisk_Group_Dollar`	`1.866686705432817` ns/iter	`1.7275501603710715` ns/iter	`1.08`
`Regex_Caret_X_Hyphen`	`7.037681361449818` ns/iter	`6.6229974767813395` ns/iter	`1.06`
`Regex_Period_Md_Dollar`	`22.982874608516077` ns/iter	`21.135237573622636` ns/iter	`1.09`
`Regex_Caret_Slash_Period_Asterisk`	`7.022868433088848` ns/iter	`6.51444534170616` ns/iter	`1.08`
`Regex_Caret_Period_Range_Dollar`	`2.0655244354177866` ns/iter	`1.9362665663493637` ns/iter	`1.07`
`Regex_Nested_Backtrack`	`31.873825225397866` ns/iter	`31.612539663690175` ns/iter	`1.01`
`JSON_Array_Of_Objects_Unique`	`382.76157997988` ns/iter	`390.97910641971976` ns/iter	`0.98`
`JSON_Parse_1`	`4560.904625567213` ns/iter	`4864.477159897726` ns/iter	`0.94`
`JSON_Parse_Real`	`6652.027980912694` ns/iter	`6841.636368151483` ns/iter	`0.97`
`JSON_Parse_Decimal`	`8089.188660823935` ns/iter	`8733.627362282696` ns/iter	`0.93`
`JSON_Parse_Schema_ISO_Language`	`5015334.805882369` ns/iter	`4714082.82208587` ns/iter	`1.06`
`JSON_Fast_Hash_Helm_Chart_Lock`	`56.31064153460527` ns/iter	`74.32733642119094` ns/iter	`0.76`
`JSON_Equality_Helm_Chart_Lock`	`121.26638282613072` ns/iter	`152.8814500374854` ns/iter	`0.79`
`JSON_Divisible_By_Decimal`	`418.81691031090264` ns/iter	`511.3288329999932` ns/iter	`0.82`
`JSON_String_Equal/10`	`6.5233511057249975` ns/iter	`8.104004815860655` ns/iter	`0.80`
`JSON_String_Equal/100`	`6.460492959976076` ns/iter	`6.56268765535864` ns/iter	`0.98`
`JSON_String_Equal_Small_By_Perfect_Hash/10`	`0.7851117900906488` ns/iter	`0.8289512998597942` ns/iter	`0.95`
`JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10`	`3.6120306130490287` ns/iter	`3.466096170470495` ns/iter	`1.04`
`JSON_String_Fast_Hash/10`	`2.439649767455297` ns/iter	`2.551975764052595` ns/iter	`0.96`
`JSON_String_Fast_Hash/100`	`2.1791954045088917` ns/iter	`2.0766664339763405` ns/iter	`1.05`
`JSON_String_Key_Hash/10`	`1.369716383005825` ns/iter	`1.3587077734129218` ns/iter	`1.01`
`JSON_String_Key_Hash/100`	`2.056467600764608` ns/iter	`2.152065274771639` ns/iter	`0.96`
`JSON_Object_Defines_Miss_Same_Length`	`2.2756928383544377` ns/iter	`2.3658803743321237` ns/iter	`0.96`
`JSON_Object_Defines_Miss_Too_Small`	`2.2785918718905984` ns/iter	`2.41916035260444` ns/iter	`0.94`
`JSON_Object_Defines_Miss_Too_Large`	`2.3207465646531524` ns/iter	`2.365628914680118` ns/iter	`0.98`
`Pointer_Object_Traverse`	`14.126037160492261` ns/iter	`14.127025053871941` ns/iter	`1.00`
`Pointer_Object_Try_Traverse`	`20.228949229628743` ns/iter	`19.61921285088449` ns/iter	`1.03`
`Pointer_Push_Back_Pointer_To_Weak_Pointer`	`158.55135248216865` ns/iter	`151.55261924218215` ns/iter	`1.05`
`Pointer_Walker_Schema_ISO_Language`	`4211526.073619583` ns/iter	`4462388.148809959` ns/iter	`0.94`
`Schema_Frame_WoT_References`	`4419837.316176005` ns/iter	`5098284.580000155` ns/iter	`0.87`
`Schema_Frame_OMC_References`	`25012275.54838689` ns/iter	`25397484.37500104` ns/iter	`0.98`
`Schema_Frame_OMC_Locations`	`24311086.03225825` ns/iter	`24899580.56666334` ns/iter	`0.98`
`Schema_Frame_ISO_Language_Locations`	`119515266.60000126` ns/iter	`66108416.66666702` ns/iter	`1.81`
`Schema_Frame_KrakenD_References`	`93579879.09999111` ns/iter	`39521460.66666905` ns/iter	`2.37`
`Schema_Frame_KrakenD_Reachable`	`720778915.999972` ns/iter	`363109603.9999875` ns/iter	`1.99`
`Schema_Iterator_ISO_Language`	`3059319.386956422` ns/iter	`1925400.3623189789` ns/iter	`1.59`
`Schema_Frame_ISO_Language_Locations_To_JSON`	`105436133.40000775` ns/iter	`85529411.37499204` ns/iter	`1.23`
`Schema_Tracker_ISO_Language`	`33392905.318185676` ns/iter	`31546621.499998648` ns/iter	`1.06`
`Schema_Tracker_ISO_Language_To_JSON`	`14500336.538462149` ns/iter	`14467301.87754903` ns/iter	`1.00`
`Schema_Format_ISO_Language_To_JSON`	`80833083.24998485` ns/iter	`78595009.22221388` ns/iter	`1.03`
`Schema_Bundle_Meta_2020_12`	`1325757.221332907` ns/iter	`1256482.8866020732` ns/iter	`1.06`
`Schema_Frame_Many_Resources_References`	`266059014.00000677` ns/iter	`261304854.00000226` ns/iter	`1.02`
`Alterschema_Check_Readibility_ISO_Language_Set_3`	`142121724.9999927` ns/iter	`158334500.00000083` ns/iter	`0.90`
`Alterschema_Check_Readibility_OMC`	`31646538.16666411` ns/iter	`32495359.86363257` ns/iter	`0.97`
`Alterschema_Apply_Readibility_KrakenD`	`527648791.5000416` ns/iter	`468355020.9999794` ns/iter	`1.13`
`EditorSchema_ForEditor_EmbeddedResources`	`10048151.68656349` ns/iter	`10265277.442856912` ns/iter	`0.98`
`URITemplateRouter_Create`	`16820.089657240373` ns/iter	`16825.522444853214` ns/iter	`1.00`
`URITemplateRouter_Match`	`166.63157763537785` ns/iter	`168.00023173943728` ns/iter	`0.99`
`URITemplateRouterView_Restore`	`13552.076998678596` ns/iter	`13248.577999494686` ns/iter	`1.02`
`URITemplateRouterView_Match`	`129.08114671435172` ns/iter	`128.14771186219875` ns/iter	`1.01`

This comment was automatically generated by workflow using github-action-benchmark.

github-actions

Benchmark (windows/msvc)

Details

Benchmark suite	Current: `f36ec16`	Previous: `d2bc5b7`	Ratio
`Regex_Lower_S_Or_Upper_S_Asterisk`	`4.114434426990436` ns/iter	`4.119435528358156` ns/iter	`1.00`
`Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar`	`4.09112380194815` ns/iter	`4.090744828733419` ns/iter	`1.00`
`Regex_Period_Asterisk`	`4.718914296248046` ns/iter	`4.722991853732388` ns/iter	`1.00`
`Regex_Group_Period_Asterisk_Group`	`4.404707499999461` ns/iter	`4.401230000000567` ns/iter	`1.00`
`Regex_Period_Plus`	`5.0354570000013155` ns/iter	`5.047347999998237` ns/iter	`1.00`
`Regex_Period`	`5.027753999997913` ns/iter	`5.035707142858266` ns/iter	`1.00`
`Regex_Caret_Period_Plus_Dollar`	`4.7172381801724645` ns/iter	`4.729687992127062` ns/iter	`1.00`
`Regex_Caret_Group_Period_Plus_Group_Dollar`	`4.410628750000001` ns/iter	`4.408490625000638` ns/iter	`1.00`
`Regex_Caret_Period_Asterisk_Dollar`	`4.406827500000077` ns/iter	`4.404493124999931` ns/iter	`1.00`
`Regex_Caret_Group_Period_Asterisk_Group_Dollar`	`4.110531808036048` ns/iter	`4.094120185882491` ns/iter	`1.00`
`Regex_Caret_X_Hyphen`	`7.244484374999059` ns/iter	`7.232751116070802` ns/iter	`1.00`
`Regex_Period_Md_Dollar`	`35.57171224235761` ns/iter	`35.59088367126095` ns/iter	`1.00`
`Regex_Caret_Slash_Period_Asterisk`	`6.913257812501326` ns/iter	`6.918378348214865` ns/iter	`1.00`
`Regex_Caret_Period_Range_Dollar`	`4.092619382308081` ns/iter	`4.107385243702517` ns/iter	`1.00`
`Regex_Nested_Backtrack`	`101.81448437499795` ns/iter	`101.83024999999901` ns/iter	`1.00`
`JSON_Array_Of_Objects_Unique`	`489.6755999998277` ns/iter	`495.3830749654449` ns/iter	`0.99`
`JSON_Parse_1`	`8931.440931065967` ns/iter	`9036.796710729945` ns/iter	`0.99`
`JSON_Parse_Real`	`15786.274553570527` ns/iter	`15824.87042468762` ns/iter	`1.00`
`JSON_Parse_Decimal`	`16158.06179436642` ns/iter	`16909.310267857945` ns/iter	`0.96`
`JSON_Parse_Schema_ISO_Language`	`6070645.535712873` ns/iter	`6134856.250000098` ns/iter	`0.99`
`JSON_Fast_Hash_Helm_Chart_Lock`	`67.78678000000582` ns/iter	`71.94875000001235` ns/iter	`0.94`
`JSON_Equality_Helm_Chart_Lock`	`261.59650000002847` ns/iter	`255.64206498404872` ns/iter	`1.02`
`JSON_Divisible_By_Decimal`	`1202.4964062501197` ns/iter	`1158.3235937500547` ns/iter	`1.04`
`JSON_String_Equal/10`	`12.298166462956004` ns/iter	`12.295601562499314` ns/iter	`1.00`
`JSON_String_Equal/100`	`12.91619107142797` ns/iter	`12.912016071429173` ns/iter	`1.00`
`JSON_String_Equal_Small_By_Perfect_Hash/10`	`1.8989409375002708` ns/iter	`1.8829224123956538` ns/iter	`1.01`
`JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10`	`12.942814285712043` ns/iter	`12.94418035714427` ns/iter	`1.00`
`JSON_String_Fast_Hash/10`	`3.7643099932777` ns/iter	`3.7707107075526336` ns/iter	`1.00`
`JSON_String_Fast_Hash/100`	`3.7708465401793085` ns/iter	`3.7755819360659566` ns/iter	`1.00`
`JSON_String_Key_Hash/10`	`4.192555141414769` ns/iter	`4.0903809448032025` ns/iter	`1.02`
`JSON_String_Key_Hash/100`	`14.380310426874463` ns/iter	`14.382922034008203` ns/iter	`1.00`
`JSON_Object_Defines_Miss_Same_Length`	`3.464364056312749` ns/iter	`3.4588527616801934` ns/iter	`1.00`
`JSON_Object_Defines_Miss_Too_Small`	`5.026122321429024` ns/iter	`5.027620999999272` ns/iter	`1.00`
`JSON_Object_Defines_Miss_Too_Large`	`4.092900855523148` ns/iter	`4.177235453887889` ns/iter	`0.98`
`Pointer_Object_Traverse`	`52.64362499998145` ns/iter	`52.937946428569056` ns/iter	`0.99`
`Pointer_Object_Try_Traverse`	`72.9966517856998` ns/iter	`72.82708705356505` ns/iter	`1.00`
`Pointer_Push_Back_Pointer_To_Weak_Pointer`	`158.33102678567255` ns/iter	`158.96486607139033` ns/iter	`1.00`
`Pointer_Walker_Schema_ISO_Language`	`12254392.85714255` ns/iter	`11053507.812498253` ns/iter	`1.11`
`Schema_Frame_WoT_References`	`10583599.999997823` ns/iter	`10025899.999997515` ns/iter	`1.06`
`Schema_Frame_OMC_References`	`45262880.000003256` ns/iter	`42548377.77777235` ns/iter	`1.06`
`Schema_Frame_OMC_Locations`	`42491606.24999604` ns/iter	`38041189.4736761` ns/iter	`1.12`
`Schema_Frame_ISO_Language_Locations`	`203509799.9999683` ns/iter	`183343366.6666527` ns/iter	`1.11`
`Schema_Frame_KrakenD_References`	`93806700.00002412` ns/iter	`83521014.28571197` ns/iter	`1.12`
`Schema_Frame_KrakenD_Reachable`	`538987099.9999857` ns/iter	`478800949.99993616` ns/iter	`1.13`
`Schema_Iterator_ISO_Language`	`4582395.4545457205` ns/iter	`4308313.749999115` ns/iter	`1.06`
`Schema_Frame_ISO_Language_Locations_To_JSON`	`259179933.33329532` ns/iter	`262516133.3333684` ns/iter	`0.99`
`Schema_Tracker_ISO_Language`	`49411342.85715114` ns/iter	`43478187.49999987` ns/iter	`1.14`
`Schema_Tracker_ISO_Language_To_JSON`	`53446400.000005014` ns/iter	`50281470.00000445` ns/iter	`1.06`
`Schema_Format_ISO_Language_To_JSON`	`204858799.9998593` ns/iter	`181352375.00001723` ns/iter	`1.13`
`Schema_Bundle_Meta_2020_12`	`2793330.303022272` ns/iter	`2778471.0843285522` ns/iter	`1.01`
`Schema_Frame_Many_Resources_References`	`1511110400.000007` ns/iter	`1434407500.000134` ns/iter	`1.05`
`Alterschema_Check_Readibility_ISO_Language_Set_3`	`336358549.99999994` ns/iter	`307623699.99990827` ns/iter	`1.09`
`Alterschema_Check_Readibility_OMC`	`62041645.454531714` ns/iter	`58309199.999985136` ns/iter	`1.06`
`Alterschema_Apply_Readibility_KrakenD`	`1032154199.9999226` ns/iter	`933527400.0000026` ns/iter	`1.11`
`EditorSchema_ForEditor_EmbeddedResources`	`28868007.999981273` ns/iter	`26758096.153859977` ns/iter	`1.08`
`URITemplateRouter_Create`	`22332.611243177267` ns/iter	`22181.782569391828` ns/iter	`1.01`
`URITemplateRouter_Match`	`202.86113156868277` ns/iter	`208.91477861990217` ns/iter	`0.97`
`URITemplateRouterView_Restore`	`29778.086704971036` ns/iter	`30031.37053571184` ns/iter	`0.99`
`URITemplateRouterView_Match`	`157.01450892860538` ns/iter	`153.82319196426408` ns/iter	`1.02`

This comment was automatically generated by workflow using github-action-benchmark.

github-actions

Benchmark (linux/gcc)

Details

Benchmark suite	Current: `f36ec16`	Previous: `120af1f`	Ratio
`URITemplateRouter_Create`	`14842.02136283442` ns/iter	`14917.918123925328` ns/iter	`0.99`
`URITemplateRouter_Match`	`156.9297318514801` ns/iter	`161.4042714570439` ns/iter	`0.97`
`URITemplateRouterView_Restore`	`7940.800685414194` ns/iter	`7942.77540507252` ns/iter	`1.00`
`URITemplateRouterView_Match`	`129.4862115741941` ns/iter	`131.1492140481696` ns/iter	`0.99`
`EditorSchema_ForEditor_EmbeddedResources`	`14252138.265308123` ns/iter	`14271568.469416244` ns/iter	`1.00`
`Alterschema_Check_Readibility_ISO_Language_Set_3`	`216831359.33335507` ns/iter	`219068208.33335888` ns/iter	`0.99`
`Alterschema_Check_Readibility_OMC`	`35691043.89999893` ns/iter	`35533262.19999917` ns/iter	`1.00`
`Alterschema_Apply_Readibility_KrakenD`	`635698341.0000794` ns/iter	`651724510.0001218` ns/iter	`0.98`
`Schema_Frame_WoT_References`	`5378966.186047245` ns/iter	`5400378.581396214` ns/iter	`1.00`
`Schema_Frame_OMC_References`	`22522475.400000986` ns/iter	`22933594.73333112` ns/iter	`0.98`
`Schema_Frame_OMC_Locations`	`21025087.70587974` ns/iter	`21175448.818184756` ns/iter	`0.99`
`Schema_Frame_ISO_Language_Locations`	`107407274.33331661` ns/iter	`109614689.16665733` ns/iter	`0.98`
`Schema_Frame_KrakenD_References`	`43179522.43749801` ns/iter	`44256593.37501031` ns/iter	`0.98`
`Schema_Frame_KrakenD_Reachable`	`608622515.9999685` ns/iter	`630504127.9999841` ns/iter	`0.97`
`Schema_Iterator_ISO_Language`	`2714536.860464758` ns/iter	`2710762.828793805` ns/iter	`1.00`
`Schema_Frame_ISO_Language_Locations_To_JSON`	`257525027.99999395` ns/iter	`252423371.3333312` ns/iter	`1.02`
`Schema_Tracker_ISO_Language`	`30681962.52173078` ns/iter	`30238946.043472543` ns/iter	`1.01`
`Schema_Tracker_ISO_Language_To_JSON`	`30654357.65217009` ns/iter	`29947769.666667532` ns/iter	`1.02`
`Schema_Format_ISO_Language_To_JSON`	`115439626.16667615` ns/iter	`114844270.83329743` ns/iter	`1.01`
`Schema_Bundle_Meta_2020_12`	`1885257.2466179663` ns/iter	`1892048.9353126315` ns/iter	`1.00`
`Schema_Frame_Many_Resources_References`	`388967768.99991894` ns/iter	`388738174.4999629` ns/iter	`1.00`
`Pointer_Object_Traverse`	`27.422036419569118` ns/iter	`27.563746041988008` ns/iter	`0.99`
`Pointer_Object_Try_Traverse`	`27.354832335059676` ns/iter	`27.287400869347763` ns/iter	`1.00`
`Pointer_Push_Back_Pointer_To_Weak_Pointer`	`167.79305062424078` ns/iter	`163.80641097016198` ns/iter	`1.02`
`Pointer_Walker_Schema_ISO_Language`	`3603322.1658031605` ns/iter	`3643573.060606176` ns/iter	`0.99`
`JSON_Array_Of_Objects_Unique`	`405.79301551190713` ns/iter	`435.8551731965354` ns/iter	`0.93`
`JSON_Parse_1`	`8390.88867437932` ns/iter	`8365.572435042164` ns/iter	`1.00`
`JSON_Parse_Real`	`12755.475923053185` ns/iter	`12861.532422269142` ns/iter	`0.99`
`JSON_Parse_Decimal`	`18775.76304446971` ns/iter	`18537.137594285712` ns/iter	`1.01`
`JSON_Parse_Schema_ISO_Language`	`4748067.635136055` ns/iter	`4657692.01324497` ns/iter	`1.02`
`JSON_Fast_Hash_Helm_Chart_Lock`	`68.95717951167211` ns/iter	`60.08389843095676` ns/iter	`1.15`
`JSON_Equality_Helm_Chart_Lock`	`156.25309009759312` ns/iter	`155.98097354530282` ns/iter	`1.00`
`JSON_Divisible_By_Decimal`	`586.3105857057501` ns/iter	`587.4208925315625` ns/iter	`1.00`
`JSON_String_Equal/10`	`6.310316246981977` ns/iter	`6.345896579123755` ns/iter	`0.99`
`JSON_String_Equal/100`	`6.933177108885` ns/iter	`6.931682069100747` ns/iter	`1.00`
`JSON_String_Equal_Small_By_Perfect_Hash/10`	`0.6236213866483271` ns/iter	`0.6247961933297185` ns/iter	`1.00`
`JSON_String_Equal_Small_By_Runtime_Perfect_Hash/10`	`13.750414192577129` ns/iter	`13.483933266366867` ns/iter	`1.02`
`JSON_String_Fast_Hash/10`	`1.9065536410940895` ns/iter	`1.907252655797016` ns/iter	`1.00`
`JSON_String_Fast_Hash/100`	`1.9072416764914246` ns/iter	`1.9309932465586486` ns/iter	`0.99`
`JSON_String_Key_Hash/10`	`1.2473629494285265` ns/iter	`1.2477879642973744` ns/iter	`1.00`
`JSON_String_Key_Hash/100`	`12.443939621735757` ns/iter	`12.437219681156554` ns/iter	`1.00`
`JSON_Object_Defines_Miss_Same_Length`	`3.426312778335483` ns/iter	`3.429248148249075` ns/iter	`1.00`
`JSON_Object_Defines_Miss_Too_Small`	`3.4252475161778064` ns/iter	`3.4253072189178684` ns/iter	`1.00`
`JSON_Object_Defines_Miss_Too_Large`	`3.4262456702288597` ns/iter	`3.4364605508442407` ns/iter	`1.00`
`Regex_Lower_S_Or_Upper_S_Asterisk`	`3.1138511988671076` ns/iter	`3.1119017210148945` ns/iter	`1.00`
`Regex_Caret_Lower_S_Or_Upper_S_Asterisk_Dollar`	`3.112645782187579` ns/iter	`3.111469480737823` ns/iter	`1.00`
`Regex_Period_Asterisk`	`3.1132247926697008` ns/iter	`3.1121942655075476` ns/iter	`1.00`
`Regex_Group_Period_Asterisk_Group`	`3.113461161508774` ns/iter	`3.122745208876438` ns/iter	`1.00`
`Regex_Period_Plus`	`2.802755951685808` ns/iter	`2.804979891674316` ns/iter	`1.00`
`Regex_Period`	`2.8013388533776284` ns/iter	`2.7997658930174016` ns/iter	`1.00`
`Regex_Caret_Period_Plus_Dollar`	`2.8024213948737717` ns/iter	`2.802826821125841` ns/iter	`1.00`
`Regex_Caret_Group_Period_Plus_Group_Dollar`	`2.800314308307212` ns/iter	`2.8049149897461465` ns/iter	`1.00`
`Regex_Caret_Period_Asterisk_Dollar`	`4.044395383388151` ns/iter	`4.045761094073178` ns/iter	`1.00`
`Regex_Caret_Group_Period_Asterisk_Group_Dollar`	`4.053275824185737` ns/iter	`4.054420469063187` ns/iter	`1.00`
`Regex_Caret_X_Hyphen`	`13.070510221694152` ns/iter	`13.6918968696612` ns/iter	`0.95`
`Regex_Period_Md_Dollar`	`41.59485368567334` ns/iter	`36.17253251385352` ns/iter	`1.15`
`Regex_Caret_Slash_Period_Asterisk`	`8.70959609307009` ns/iter	`8.713504468128033` ns/iter	`1.00`
`Regex_Caret_Period_Range_Dollar`	`4.045997647215169` ns/iter	`4.043163286623002` ns/iter	`1.00`
`Regex_Nested_Backtrack`	`66.0985701775858` ns/iter	`57.776246042934645` ns/iter	`1.14`

This comment was automatically generated by workflow using github-action-benchmark.

cubic-dev-ai bot reviewed Feb 27, 2026

View reviewed changes

augmentcode bot reviewed Feb 27, 2026

View reviewed changes

Fix a URI resolution port bug

f36ec16

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>

jviotti changed the title ~~Fix a URI resolution port bug~~ Fix various URI resolution bugs Feb 27, 2026

jviotti force-pushed the uri-resolve-bug-port branch from 2740deb to f36ec16 Compare February 27, 2026 19:54

jviotti merged commit d2bc5b7 into main Feb 27, 2026
2 checks passed

jviotti deleted the uri-resolve-bug-port branch February 27, 2026 19:55

github-actions bot reviewed Feb 27, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix various URI resolution bugs#2278

Fix various URI resolution bugs#2278
jviotti merged 1 commit intomainfrom
uri-resolve-bug-port

jviotti commented Feb 27, 2026

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

augmentcode bot commented Feb 27, 2026 •

edited

Loading

Uh oh!

augmentcode bot left a comment

Uh oh!

augmentcode bot Feb 27, 2026

Uh oh!

Uh oh!

github-actions bot left a comment

Uh oh!

github-actions bot left a comment

Uh oh!

github-actions bot left a comment

Uh oh!

github-actions bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

jviotti commented Feb 27, 2026

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

augmentcode bot commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

augmentcode bot left a comment

Choose a reason for hiding this comment

Uh oh!

augmentcode bot Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Benchmark (linux/llvm)

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Benchmark (macos/llvm)

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Benchmark (windows/msvc)

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Benchmark (linux/gcc)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

augmentcode bot commented Feb 27, 2026 •

edited

Loading