Fixed accessing DataSnapshot with multiple paths#113
Open
rhodgkins wants to merge 6 commits intosoumak77:masterfrom
Open
Fixed accessing DataSnapshot with multiple paths#113rhodgkins wants to merge 6 commits intosoumak77:masterfrom
rhodgkins wants to merge 6 commits intosoumak77:masterfrom
Conversation
881ba39 to
fb7ef54
Compare
Contributor
Author
|
I've fixed issue with accessing child data with number paths (for array indexes), including failing test case. |
9eb10b9 to
f596a86
Compare
|
Hi @rhodgkins, thanks for the contribution. As you may have guessed, this repo is no longer used (see #160), but work is continuing on my fork for now, and we will be making a release in early December. I've opened a new PR with these changes. (Also, if you still happen to depend on |
|
The sister PR has now been merged. Look for a release soon. Thanks again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this following data snapshot:
Calling
snapshot.child('foo/bar').val()should beval- but as.child(and also.hasChild) just checksthis._snapshotdatafor thekeywithout splitting it by/it returnsnull. Includes tests.Also it would be useful to have this available so code that interacts with DataSnapshots directly (it might merge various snapshots into a single object, etc.) can be tested, so I've exported snapshot.js as
DataSnapshot.Finally I've also added node 8 to the travis test matrix - hope this is ok!