You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR changes the behavior of Solid's error handling, mainly on the concept of "casting errors". Solid has an internal mechanism wrapping thrown values if the value isn't an Error instance.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Why? It was this way before. We intentionally went to normalizing errors. I admit it was mostly for serialization so I could see the argument for reverting it now. But on the other hand I feel as much temptation to normalize farther to prevent serialization errors for things that random libraries pass us that can't be serialized.
@ryansolid it's not exactly that way before. We used to check if the error is truthy, and not if the error existed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
THIS IS A BREAKING CHANGE
This PR changes the behavior of Solid's error handling, mainly on the concept of "casting errors". Solid has an internal mechanism wrapping thrown values if the value isn't an
Errorinstance.