Fix #42 Bug with Install Instructions / Requirements#43
Open
RyanJField wants to merge 2 commits intosoftwaresaved:masterfrom
Open
Fix #42 Bug with Install Instructions / Requirements#43RyanJField wants to merge 2 commits intosoftwaresaved:masterfrom
RyanJField wants to merge 2 commits intosoftwaresaved:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #42
Description
An issue was found with FRSM-13-R1-1, it was identified that when a nested data type was checked the key was not removed from the check key list, causing the loop to continue checking and having the potential to override the found key. Addionally it was found that on errors while decoding bytes to string was set to default ("strict") this may cause issues with non utf-8 parsable characters. Subsequently this was changed to "replace".
Additionally pyproject.toml was added to the
dependenciesas this can be a recognised python dependencies file (enhancing FRSM-13-R1-2). This might need to be validated.Related issue: #42
Motivation and context
Fixes issue which prevents FRSM-13-R1-1/2 from passing
How has this been tested?
Tested using the swagger openAPI using the repo mentioned in the bug as well as repos which passed and failed this check including https://github.com/FAIRDataPipeline/pyDataPipeline
The test_evaluation.py tests and test_evaluation_software.yaml helper were updated to test these new changes.
Screenshots (if appropriate)
Types of changes
Checklist