Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the configurePickFirsts function was checking against supportedPackages instead of projectPackages, causing pickFirst rules to not be applied for packages that are in the project but not yet supported by the prebuilds system. The fix ensures that pickFirst rules are correctly configured for all packages present in the project.
Changes:
- Changed
configurePickFirststo useprojectPackagesinstead ofsupportedPackages - Simplified the pickFirst configuration by replacing explicit architecture iteration with a wildcard pattern
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...es/gradle-client/rnrepo-plugin/src/main/kotlin/org/rnrepo/tools/prebuilds/PrebuildsPlugin.kt
Outdated
Show resolved
Hide resolved
...es/gradle-client/rnrepo-plugin/src/main/kotlin/org/rnrepo/tools/prebuilds/PrebuildsPlugin.kt
Outdated
Show resolved
Hide resolved
...es/gradle-client/rnrepo-plugin/src/main/kotlin/org/rnrepo/tools/prebuilds/PrebuildsPlugin.kt
Show resolved
Hide resolved
…o/tools/prebuilds/PrebuildsPlugin.kt Co-authored-by: Copilot <[email protected]>
kmagiera
left a comment
kmagiera
left a comment
There was a problem hiding this comment.
Why is this needed? I understand we need pickfirst because reanimated aars have libworklets. But in that instance the solutions should be to not distribute libworklets with reanimated. The PR description should mention the motivation for this change
📝 Description
Always add pickfirst if package is in project, so that prebuilds resolution works correctly
🎯 Type of Change