feat(iOS, Stack): Migrate to new invalidate method#3368
Draft
t0maboro wants to merge 5 commits into@t0maboro/tabs-invalidationfrom
Draft
feat(iOS, Stack): Migrate to new invalidate method#3368t0maboro wants to merge 5 commits into@t0maboro/tabs-invalidationfrom
t0maboro wants to merge 5 commits into@t0maboro/tabs-invalidationfrom
Conversation
c9c2b29 to
9b286c3
Compare
t0maboro
commented
Nov 3, 2025
| if (!self->_toBeDeletedScreens.empty()) { | ||
| __weak RNSScreenStackView *weakSelf = self; | ||
| // We want to run after container updates are performed (transitions etc.) | ||
| dispatch_async(dispatch_get_main_queue(), ^{ |
Contributor
Author
There was a problem hiding this comment.
note: it seems that we can consider removing that delay as invalidateImpl is doing the same right now, but I decided to leave it as it is, because we're invalidating a bit later and the code will be dropped when we stop supporting <0.82
kligarski
reviewed
Nov 4, 2025
788b570 to
e1cd715
Compare
2 tasks
Contributor
Author
|
Switching to draft until we drop support for RN versions before 0.82 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the logic responsible for triggering the
invalidatecallback. We're now aligning the logic to useRCTComponentViewProtocolcallback, when available.Depending on the React Native architecture and version, the invalidate mechanism behaves differently:
invalidateflow continues to use theRCTInvalidatingprotocol.RCTComponentViewProtocol. This PR enables usage of that callback.Note: I'm using some common code from: #3367
Changes
RNSReactNativeVersionUtilsin stack - for runtime checks as the commit with the new method in protocol was CP to 0.82 releaseinvalidateImplTest code and steps to reproduce
Check any example with native stack and verify whether
invalidatecallback is called from a proper path, e.g. by hitting a breakpoint.Checklist